Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gsp generation with file extension #27144

Merged
merged 6 commits into from
Jul 15, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 13, 2021

Fixes #11831
Fixes #12212

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jul 13, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 14, 2021

Failing test suites

Commit: 2b0d157

test/integration/build-indicator/test/index.test.js

  • Build Activity Indicator > Enabled > Shows build indicator when page is built from modifying
Expand output

● Build Activity Indicator › Enabled › Shows build indicator when page is built from modifying

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: null

  62 |       const wasVisible = await browser.eval('window.showedBuilder')
  63 |
> 64 |       expect(wasVisible).toBe(true)
     |                          ^
  65 |       await fs.writeFile(pagePath, origContent, 'utf8')
  66 |       await browser.close()
  67 |     })

  at Object.<anonymous> (integration/build-indicator/test/index.test.js:64:26)

test/acceptance/ReactRefreshLogBox.dev.test.js

  • server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=91.0.4472.114)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1415:3)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review July 14, 2021 17:38
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi requested a review from ijjk July 15, 2021 09:10
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ijjk
Copy link
Member

ijjk commented Jul 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-build-ext Change
buildDuration 15.7s 17.2s ⚠️ +1.5s
buildDurationCached 3.8s 3.7s -8ms
nodeModulesSize 49.4 MB 49.4 MB ⚠️ +1.11 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-build-ext Change
/ failed reqs 0 0
/ total time (seconds) 2.691 2.855 ⚠️ +0.16
/ avg req/sec 928.92 875.74 ⚠️ -53.18
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.548 1.702 ⚠️ +0.15
/error-in-render avg req/sec 1615.37 1469.25 ⚠️ -146.12
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-build-ext Change
359.HASH.js gzip 2.96 kB 2.96 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.9 kB 20.9 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.4 kB 67.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-build-ext Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-build-ext Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.58 kB 5.58 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13.9 kB 13.9 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-build-ext Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-build-ext Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-build-ext Change
buildDuration 12.5s 12.7s ⚠️ +145ms
buildDurationCached 5s 5.1s ⚠️ +158ms
nodeModulesSize 49.4 MB 49.4 MB ⚠️ +1.11 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-build-ext Change
/ failed reqs 0 0
/ total time (seconds) 2.769 2.854 ⚠️ +0.08
/ avg req/sec 902.74 875.83 ⚠️ -26.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.688 1.673 -0.01
/error-in-render avg req/sec 1481.17 1493.94 +12.77
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-build-ext Change
14.HASH.js gzip 2.98 kB 2.98 kB
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 8.39 kB 8.39 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-build-ext Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-build-ext Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 230 B 230 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 297 B 297 B
withRouter-HASH.js gzip 293 B 293 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.93 kB 8.93 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-build-ext Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-build-ext Change
index.html gzip 574 B 574 B
link.html gzip 588 B 588 B
withRouter.html gzip 568 B 568 B
Overall change 1.73 kB 1.73 kB
Commit: 8be0c8c

@kodiakhq kodiakhq bot merged commit 71665b2 into vercel:canary Jul 15, 2021
@huozhi huozhi deleted the fix-build-ext branch July 15, 2021 18:56
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
Fixes vercel#11831 
Fixes vercel#12212

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants