Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention running local changes inside monorepo #27050

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 9, 2021

This updates the contributing doc to mention an easier workflow for running Next.js apps with additional dependencies locally from within the Next.js monorepo instead of installing it via package.json

x-ref: #19736
x-ref: #13272

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jul 9, 2021
@ijjk
Copy link
Member Author

ijjk commented Jul 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/contributing Change
buildDuration 15.3s 15.4s ⚠️ +110ms
buildDurationCached 3.6s 3.5s -99ms
nodeModulesSize 49.3 MB 49.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/contributing Change
/ failed reqs 0 0
/ total time (seconds) 2.42 2.498 ⚠️ +0.08
/ avg req/sec 1033.15 1000.84 ⚠️ -32.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.361 1.377 ⚠️ +0.02
/error-in-render avg req/sec 1836.7 1815.8 ⚠️ -20.9
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/contributing Change
359.HASH.js gzip 3.09 kB 3.09 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.6 kB 20.6 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/contributing Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js update/contributing Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.69 kB 5.69 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/contributing Change
_buildManifest.js gzip 419 B 419 B
Overall change 419 B 419 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/contributing Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/contributing Change
buildDuration 12s 12s ⚠️ +8ms
buildDurationCached 4.8s 4.9s ⚠️ +121ms
nodeModulesSize 49.3 MB 49.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/contributing Change
/ failed reqs 0 0
/ total time (seconds) 2.479 2.543 ⚠️ +0.06
/ avg req/sec 1008.52 983.15 ⚠️ -25.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.393 1.414 ⚠️ +0.02
/error-in-render avg req/sec 1795.07 1767.44 ⚠️ -27.63
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/contributing Change
14.HASH.js gzip 3.11 kB 3.11 kB
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.81 kB 7.81 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/contributing Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/contributing Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.83 kB 3.83 kB
amp-HASH.js gzip 531 B 531 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 230 B 230 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 297 B 297 B
withRouter-HASH.js gzip 293 B 293 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.98 kB 8.98 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/contributing Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/contributing Change
index.html gzip 574 B 574 B
link.html gzip 586 B 586 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: fba5ad4

@ijjk ijjk merged commit 6eaa685 into vercel:canary Jul 9, 2021
@ijjk ijjk deleted the update/contributing branch July 9, 2021 16:39
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants