WIP Performance tracing image optimizer #27047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
changed the title
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| buildDuration | 14.2s | 14.3s | |
| buildDurationCached | 3.3s | 3.4s | |
| nodeModulesSize | 49.3 MB | 72.7 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.326 | 2.345 | |
| / avg req/sec | 1074.75 | 1066.04 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.261 | 1.288 | |
| /error-in-render avg req/sec | 1982.08 | 1940.77 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| 359.HASH.js gzip | 3.09 kB | 3.09 kB | ✓ |
| framework-HASH.js gzip | 42 kB | 42 kB | ✓ |
| main-HASH.js gzip | 20.6 kB | 20.6 kB | ✓ |
| webpack-HASH.js gzip | 1.49 kB | 1.49 kB | ✓ |
| Overall change | 67.2 kB | 67.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 803 B | 803 B | ✓ |
| _error-HASH.js gzip | 3.18 kB | 3.18 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 329 B | 329 B | ✓ |
| hooks-HASH.js gzip | 903 B | 903 B | ✓ |
| image-HASH.js gzip | 5.69 kB | 5.73 kB | |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 319 B | 319 B | ✓ |
| withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 14.1 kB | 14.2 kB |
Client Build Manifests
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 419 B | 419 B | ✓ |
| Overall change | 419 B | 419 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| index.html gzip | 531 B | 531 B | ✓ |
| link.html gzip | 544 B | 544 B | ✓ |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -13,7 +13,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Fhooks-4e38b05900fed34fcf34.js"
],
"/image": [
- "static\u002Fchunks\u002Fpages\u002Fimage-7b2a3db6fef72dcc481e.js"
+ "static\u002Fchunks\u002Fpages\u002Fimage-1318788852d326af85ca.js"
],
"/link": ["static\u002Fchunks\u002Fpages\u002Flink-461e3656f357dad048d3.js"],
"/routerDirect": [Diff for image-HASH.js
@@ -1498,7 +1498,7 @@ Also adds support for deduplicated `key` properties
height: 1347,
width: 1626,
blurDataURL:
- "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAHCAQAAACfUMTVAAAAP0lEQVR42jXIQQqDUBTF0Lf/rdZZB9W2/0REDNwbyATxaJSuCZlafn3tDmHq49Vm87ZkpKPd8n9CF+7XFOImJ8SebtyxyeM6AAAAAElFTkSuQmCC"
+ "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAGCAYAAAD+Bd/7AAAACXBIWXMAAAsTAAALEwEAmpwYAAAAT0lEQVQImX2OsQoAMQhD+///KAVBxKGLTi7mqEe36wkJQeHFAQBVddXY9jdjm7tDVVvMDDPrYxN2iAgQEeacEBGstZCZL+FWcfZN+HruVDzOPbw+4RztFgAAAABJRU5ErkJggg=="
}; // CONCATENATED MODULE: ./pages/image.js
function ImagePage(props) {
return /*#__PURE__*/ (0, jsx_runtime.jsxs)(jsx_runtime.Fragment, {Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| buildDuration | 11.5s | 11.5s | -9ms |
| buildDurationCached | 4.7s | 4.6s | -55ms |
| nodeModulesSize | 49.3 MB | 72.7 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.35 | 2.396 | |
| / avg req/sec | 1063.84 | 1043.51 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.284 | 1.321 | |
| /error-in-render avg req/sec | 1946.68 | 1892.28 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| 14.HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
| 677f882d2ed8..HASH.js gzip | 13.9 kB | 13.9 kB | ✓ |
| framework.HASH.js gzip | 41.8 kB | 41.8 kB | ✓ |
| main-HASH.js gzip | 7.81 kB | 7.81 kB | ✓ |
| webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
| Overall change | 67.8 kB | 67.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 791 B | 791 B | ✓ |
| _error-HASH.js gzip | 3.83 kB | 3.83 kB | ✓ |
| amp-HASH.js gzip | 531 B | 531 B | ✓ |
| css-HASH.js gzip | 333 B | 333 B | ✓ |
| hooks-HASH.js gzip | 910 B | 910 B | ✓ |
| index-HASH.js gzip | 230 B | 230 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 297 B | 297 B | ✓ |
| withRouter-HASH.js gzip | 293 B | 293 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.98 kB | 8.98 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 418 B | 418 B | ✓ |
| Overall change | 418 B | 418 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js replace-squoosh-with-sharp | Change | |
|---|---|---|---|
| index.html gzip | 574 B | 574 B | ✓ |
| link.html gzip | 586 B | 586 B | ✓ |
| withRouter.html gzip | 569 B | 569 B | ✓ |
| Overall change | 1.73 kB | 1.73 kB | ✓ |
Failing test suitesCommit: 5511011 test/integration/image-optimizer/test/index.test.js
Expand output● Image Optimizer › dev support w/o next.config.js › should not change the color type of a png ● Image Optimizer › dev support with next.config.js › should not change the color type of a png ● Image Optimizer › Server support w/o next.config.js › should not change the color type of a png ● Image Optimizer › Server support with next.config.js › should not change the color type of a png ● Image Optimizer › Serverless support with next.config.js › should not change the color type of a png test/integration/image-component/default/test/static.test.js
Expand output● Static Image Component Tests › Should add a blurry placeholder to statically imported jpg ● Static Image Component Tests › Should add a blurry placeholder to statically imported png |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #27043 to compare squoosh vs sharp performance