Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename next/script interface Props to ScriptProps #26990

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Jul 7, 2021

This will ensure next/script follows the same naming convention as next/image. For example:

import Image, { ImageProps } from 'next/image'
import Script, { ScriptProps } from 'next/script'

Fixes #26290

ijjk
ijjk previously approved these changes Jul 7, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 7, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js rename-script-props Change
buildDuration 15.5s 15.6s ⚠️ +123ms
buildDurationCached 3.6s 3.6s -1ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +206 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js rename-script-props Change
/ failed reqs 0 0
/ total time (seconds) 2.69 2.656 -0.03
/ avg req/sec 929.25 941.21 +11.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.781 1.631 -0.15
/error-in-render avg req/sec 1403.84 1533.04 +129.2
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js rename-script-props Change
359.HASH.js gzip 3.09 kB 3.09 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.6 kB 20.6 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js rename-script-props Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js rename-script-props Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.58 kB 5.58 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 14 kB 14 kB
Client Build Manifests
vercel/next.js canary vercel/next.js rename-script-props Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js rename-script-props Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js rename-script-props Change
buildDuration 12s 12.2s ⚠️ +212ms
buildDurationCached 5.1s 4.7s -354ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +206 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js rename-script-props Change
/ failed reqs 0 0
/ total time (seconds) 2.683 2.589 -0.09
/ avg req/sec 931.69 965.71 +34.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.724 1.614 -0.11
/error-in-render avg req/sec 1449.92 1548.49 +98.57
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js rename-script-props Change
14.HASH.js gzip 3.11 kB 3.11 kB
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.81 kB 7.81 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js rename-script-props Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js rename-script-props Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.83 kB 3.83 kB
amp-HASH.js gzip 531 B 531 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 230 B 230 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 297 B 297 B
withRouter-HASH.js gzip 293 B 293 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.98 kB 8.98 kB
Client Build Manifests
vercel/next.js canary vercel/next.js rename-script-props Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js rename-script-props Change
index.html gzip 575 B 575 B
link.html gzip 586 B 586 B
withRouter.html gzip 568 B 568 B
Overall change 1.73 kB 1.73 kB
Commit: 0fb2591

@kodiakhq kodiakhq bot merged commit f1e6bc9 into canary Jul 7, 2021
@kodiakhq kodiakhq bot deleted the rename-script-props branch July 7, 2021 16:35
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
This will ensure `next/script` follows the same naming convention as `next/image`. For example:

```js
import Image, { ImageProps } from 'next/image'
import Script, { ScriptProps } from 'next/script'
```

Fixes vercel#26290
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants