Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: (rewrites) incorrect parsing of destination query #26619

Merged
merged 12 commits into from
Jul 6, 2021

Conversation

lsndr
Copy link
Contributor

@lsndr lsndr commented Jun 25, 2021

fixes #26609

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Documentation / Examples

  • Make sure the linting passes

@lsndr
Copy link
Contributor Author

lsndr commented Jun 26, 2021

Azure tests have failed for the reasons, not related to my commits

styfle
styfle previously approved these changes Jul 6, 2021
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 6, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lsndr/next.js dev-fix Change
buildDuration 13.5s 13.1s -411ms
buildDurationCached 3.3s 3.2s -87ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +87 B
Page Load Tests Overall increase ✓
vercel/next.js canary lsndr/next.js dev-fix Change
/ failed reqs 0 0
/ total time (seconds) 2.493 2.534 ⚠️ +0.04
/ avg req/sec 1002.97 986.42 ⚠️ -16.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.618 1.552 -0.07
/error-in-render avg req/sec 1545.18 1610.6 +65.42
Client Bundles (main, webpack, commons)
vercel/next.js canary lsndr/next.js dev-fix Change
359.HASH.js gzip 3.09 kB 3.09 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.6 kB 20.6 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lsndr/next.js dev-fix Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary lsndr/next.js dev-fix Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 322 B 322 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.42 kB 8.42 kB
Client Build Manifests
vercel/next.js canary lsndr/next.js dev-fix Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary lsndr/next.js dev-fix Change
index.html gzip 523 B 523 B
link.html gzip 537 B 537 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary lsndr/next.js dev-fix Change
buildDuration 11.7s 11.4s -264ms
buildDurationCached 4.7s 4.6s -165ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +87 B
Page Load Tests Overall increase ✓
vercel/next.js canary lsndr/next.js dev-fix Change
/ failed reqs 0 0
/ total time (seconds) 2.497 2.546 ⚠️ +0.05
/ avg req/sec 1001.29 981.85 ⚠️ -19.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.649 1.603 -0.05
/error-in-render avg req/sec 1516.17 1559.76 +43.59
Client Bundles (main, webpack, commons)
vercel/next.js canary lsndr/next.js dev-fix Change
14.HASH.js gzip 3.11 kB 3.11 kB
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.81 kB 7.81 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary lsndr/next.js dev-fix Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary lsndr/next.js dev-fix Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.83 kB 3.83 kB
amp-HASH.js gzip 531 B 531 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 295 B 295 B
withRouter-HASH.js gzip 292 B 292 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.98 kB 8.98 kB
Client Build Manifests
vercel/next.js canary lsndr/next.js dev-fix Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary lsndr/next.js dev-fix Change
index.html gzip 569 B 569 B
link.html gzip 581 B 581 B
withRouter.html gzip 561 B 561 B
Overall change 1.71 kB 1.71 kB
Commit: 03142be

kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Jul 6, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
fixes vercel#26609

## Bug

- [x]  Related issues linked using fixes #number
- [x]   Integration tests added

## Documentation / Examples

- [x]  Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

«Rewrite mechanism» transforms array parameters of query of destination link into strings
3 participants