ESLint: custom directories from next.config.js #26401

michalbundyra · 2021-06-20T20:51:01Z

Attempt to fix #26393

~~Sorry, I wasn't able to run tests on local, but I hope at least test should be valid.~~
Edit: Tests are working correctly on my local :)

fixes #26393

Bug

Related issues linked using fixes #26393
Integration tests added

housseindjirdeh

Thanks for this @michalbundyra. The workaround for next lint was to use the --dir flag instead, but I agree that it's probably more intuitive that config.eslint.dirs also works the same for both next lint and next build :)

One comment around docs, otherwise looks good!

One tiny

packages/next/cli/next-lint.ts

Attempt to fix vercel#26393 Sorry, I wasn't able to run tests on local, but I hope at least test should be valid.

@housseindjirdeh

- per @housseindjirdeh

michalbundyra · 2021-06-21T21:06:31Z

@housseindjirdeh thanks for the review. Documentation is now updated and branch rebased. Thanks

housseindjirdeh

Thanks, LGTM!

docs/basic-features/eslint.md

Co-authored-by: Houssein Djirdeh <[email protected]>

leerob

Docs look okay!

bnjmnt4n · 2021-07-02T03:15:29Z

Hi, just wanted to check is there anything blocking this? The current behaviour was a little confusing, and I'd look forward to seeing this merged.

…tom-directories # Conflicts: # test/integration/eslint/test/index.test.js

ijjk · 2021-07-25T03:46:00Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
buildDuration	18s	17.9s	-107ms
buildDurationCached	4s	3.9s	-136ms
nodeModulesSize	49.5 MB	49.5 MB	⚠️ +301 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.076	3.103	⚠️ +0.03
/ avg req/sec	812.68	805.73	⚠️ -6.95
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.915	2.018	⚠️ +0.1
/error-in-render avg req/sec	1305.44	1238.97	⚠️ -66.47

Client Bundles (main, webpack, commons)

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
359.HASH.js gzip	2.96 kB	2.96 kB	✓
745.HASH.js gzip	180 B	180 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	21 kB	21 kB	✓
webpack-HASH.js gzip	1.53 kB	1.53 kB	✓
Overall change	67.9 kB	67.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
_app-HASH.js gzip	803 B	803 B	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	554 B	554 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	2.28 kB	2.28 kB	✓
hooks-HASH.js gzip	903 B	903 B	✓
image-HASH.js gzip	5.63 kB	5.63 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	19.1 kB	19.1 kB	✓

Client Build Manifests

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
_buildManifest.js gzip	489 B	489 B	✓
Overall change	489 B	489 B	✓

Rendered Page Sizes

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
index.html gzip	531 B	531 B	✓
link.html gzip	542 B	542 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
buildDuration	13.9s	13.9s	⚠️ +2ms
buildDurationCached	5.5s	5.4s	-74ms
nodeModulesSize	49.5 MB	49.5 MB	⚠️ +301 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.102	2.993	-0.11
/ avg req/sec	805.8	835.32	+29.52
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.916	1.892	-0.02
/error-in-render avg req/sec	1304.57	1321.33	+16.76

Client Bundles (main, webpack, commons)

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
17.HASH.js gzip	2.98 kB	2.98 kB	✓
18.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	8.4 kB	8.4 kB	✓
webpack-HASH.js gzip	1.22 kB	1.22 kB	✓
Overall change	68.5 kB	68.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
_app-HASH.js gzip	791 B	791 B	✓
_error-HASH.js gzip	3.76 kB	3.76 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.02 kB	3.02 kB	✓
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.6 kB	17.6 kB	✓

Client Build Manifests

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	michalbundyra/next.js hotfix/eslint-custom-directories	Change
index.html gzip	576 B	576 B	✓
link.html gzip	588 B	588 B	✓
withRouter.html gzip	569 B	569 B	✓
Overall change	1.73 kB	1.73 kB	✓

Commit: 8313676

ijjk

Thanks for the PR!

the behavior of the `eslint.dirs` config option was changed in #26401. this pr adjusts the doc comment accordingly. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes

ijjk · 2021-07-26T18:00:51Z

Hi, this is now available in v11.0.2-canary.22 of Next.js, please update and give it a try!

Attempt to fix vercel#26393 ~~Sorry, I wasn't able to run tests on local, but I hope at least test should be valid.~~ Edit: Tests are working correctly on my local :) fixes vercel#26393 ## Bug - [x] Related issues linked using `fixes vercel#26393` - [x] Integration tests added

the behavior of the `eslint.dirs` config option was changed in vercel#26401. this pr adjusts the doc comment accordingly. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes

michalbundyra requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners June 20, 2021 20:51

ijjk added the type: next label Jun 20, 2021

housseindjirdeh suggested changes Jun 21, 2021

View reviewed changes

packages/next/cli/next-lint.ts Show resolved Hide resolved

michalbundyra added 2 commits June 21, 2021 22:05

ESLint: custom directories from next.config.js

c781243

Attempt to fix vercel#26393 Sorry, I wasn't able to run tests on local, but I hope at least test should be valid.

Update documentation

516bfe8

- per @housseindjirdeh

michalbundyra force-pushed the hotfix/eslint-custom-directories branch from 9da5586 to 516bfe8 Compare June 21, 2021 21:05

michalbundyra requested a review from leerob as a code owner June 21, 2021 21:05

ijjk added the type: documentation label Jun 21, 2021

housseindjirdeh previously approved these changes Jun 22, 2021

View reviewed changes

docs/basic-features/eslint.md Outdated Show resolved Hide resolved

Update docs/basic-features/eslint.md

1d66d16

Co-authored-by: Houssein Djirdeh <[email protected]>

michalbundyra dismissed housseindjirdeh’s stale review via 1d66d16 June 22, 2021 14:06

leerob previously approved these changes Jun 22, 2021

View reviewed changes

housseindjirdeh mentioned this pull request Jul 8, 2021

Eslint doesn't work for components outside "pages" dir #26959

Closed

Merge remote-tracking branch 'upstream/canary' into hotfix/eslint-cus…

6c52452

…tom-directories # Conflicts: # test/integration/eslint/test/index.test.js

ijjk dismissed leerob’s stale review via 6c52452 July 25, 2021 03:25

michalbundyra requested review from huozhi, padmaia and styfle as code owners July 25, 2021 03:25

lint-fix

8313676

ijjk approved these changes Jul 25, 2021

View reviewed changes

kodiakhq bot merged commit 7fe8a00 into vercel:canary Jul 25, 2021

stefanprobst mentioned this pull request Jul 25, 2021

Update eslint doc comment #27478

Merged

10 tasks

michalbundyra deleted the hotfix/eslint-custom-directories branch July 30, 2021 13:38

rtritto mentioned this pull request Aug 18, 2021

Gitlab CI timeout in "next lint" with Next.js 11.1.0 #28194

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ESLint: custom directories from next.config.js #26401

ESLint: custom directories from next.config.js #26401

michalbundyra commented Jun 20, 2021 •

edited

Loading

housseindjirdeh left a comment

michalbundyra commented Jun 21, 2021

housseindjirdeh left a comment

leerob left a comment

bnjmnt4n commented Jul 2, 2021

ijjk commented Jul 25, 2021

ijjk left a comment

ijjk commented Jul 26, 2021

ESLint: custom directories from next.config.js #26401

ESLint: custom directories from next.config.js #26401

Conversation

michalbundyra commented Jun 20, 2021 • edited Loading

Bug

housseindjirdeh left a comment

Choose a reason for hiding this comment

michalbundyra commented Jun 21, 2021

housseindjirdeh left a comment

Choose a reason for hiding this comment

leerob left a comment

Choose a reason for hiding this comment

bnjmnt4n commented Jul 2, 2021

ijjk commented Jul 25, 2021

Stats from current PR

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Jul 26, 2021

michalbundyra commented Jun 20, 2021 •

edited

Loading