server doesn't need to be contenthashing at all #25251

sokra · 2021-05-19T09:16:28Z

contenthashing is not useful for the server

cc @ijjk

ijjk · 2021-05-19T17:47:53Z

Failing test suites

Commit: 9fb2270

test/integration/build-output/test/index.test.js

Build Output > Basic Application Output > should not deviate from snapshot
Build Output > Basic Application Output (with experimental.gzipSize: true) > should not deviate from snapshot

Expand output

● Build Output › Basic Application Output (with experimental.gzipSize: true) › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 66.5
Received: 66.4

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.09999999999999432

  130 |           expect(err404Size.endsWith('kB')).toBe(true)
  131 |
> 132 |           expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.5 : 203, 1)
      |                                               ^
  133 |           expect(err404FirstLoad.endsWith('kB')).toBe(true)
  134 |
  135 |           expect(parseFloat(sharedByAll)).toBeCloseTo(gz ? 63.4 : 195, 1)

  at Object.<anonymous> (integration/build-output/test/index.test.js:132:47)

● Build Output › Basic Application Output › should not deviate from snapshot

expect(received).toBeCloseTo(expected, precision)

Expected: 66.5
Received: 66.4

Expected precision:    1
Expected difference: < 0.05
Received difference:   0.09999999999999432

  130 |           expect(err404Size.endsWith('kB')).toBe(true)
  131 |
> 132 |           expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.5 : 203, 1)
      |                                               ^
  133 |           expect(err404FirstLoad.endsWith('kB')).toBe(true)
  134 |
  135 |           expect(parseFloat(sharedByAll)).toBeCloseTo(gz ? 63.4 : 195, 1)

  at Object.<anonymous> (integration/build-output/test/index.test.js:132:47)

ijjk · 2021-05-19T18:18:30Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
buildDuration	15.9s	16s	⚠️ +48ms
buildDurationCached	4.9s	4.7s	-262ms
nodeModulesSize	46.7 MB	46.7 MB	-204 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.683	2.719	⚠️ +0.04
/ avg req/sec	931.86	919.3	⚠️ -12.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.57	1.573	0
/error-in-render avg req/sec	1592.57	1589.62	⚠️ -2.95

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
index.html gzip	559 B	559 B	✓
link.html gzip	569 B	569 B	✓
withRouter.html gzip	556 B	556 B	✓
Overall change	1.68 kB	1.68 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
buildDuration	18.5s	18.4s	-90ms
buildDurationCached	5.8s	5.8s	-62ms
nodeModulesSize	46.7 MB	46.7 MB	-204 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	19.4 kB	19.4 kB	✓
webpack-HASH.js gzip	994 B	994 B	✓
Overall change	59.7 kB	59.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_app-HASH.js gzip	1.02 kB	1.02 kB	✓
_error-HASH.js gzip	3.06 kB	3.06 kB	✓
amp-HASH.js gzip	526 B	526 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	331 B	331 B	✓
withRouter-HASH.js gzip	329 B	329 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.54 kB	8.54 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_error.js	17 kB	16.9 kB	-77 B
404.html	2.42 kB	2.42 kB	✓
500.html	2.41 kB	2.41 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.61 kB	1.61 kB	✓
css.html	1.79 kB	1.79 kB	✓
hooks.html	1.67 kB	1.67 kB	✓
index.js	17.3 kB	17.2 kB	-77 B
link.js	17.6 kB	17.4 kB	-133 B
routerDirect.js	17.5 kB	17.4 kB	-135 B
withRouter.js	17.6 kB	17.4 kB	-133 B
Overall change	108 kB	107 kB	-555 B

Webpack 4 Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
buildDuration	13.3s	13.3s	-8ms
buildDurationCached	5.6s	5.6s	-5ms
nodeModulesSize	46.7 MB	46.7 MB	-204 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.716	2.712	0
/ avg req/sec	920.6	921.81	+1.21
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.578	1.524	-0.05
/error-in-render avg req/sec	1584.04	1640.5	+56.46

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.25 kB	7.25 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.38 kB	9.38 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/server-content-hash	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 993c8f5

@ijjk

contenthashing is not useful for the server cc @ijjk

server doesn't need to be contenthashing at all

5d9ce70

ijjk added the type: next label May 19, 2021

This comment has been minimized.

Sign in to view

sokra marked this pull request as ready for review May 19, 2021 09:28

sokra requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners May 19, 2021 09:28

ijjk previously approved these changes May 19, 2021

View reviewed changes

Merge branch 'canary' into bugfix/server-content-hash

9fb2270

This comment has been minimized.

Sign in to view

update size

993c8f5

ijjk dismissed their stale review via 993c8f5 May 19, 2021 18:06

ijjk approved these changes May 19, 2021

View reviewed changes

kodiakhq bot merged commit 96f9945 into canary May 19, 2021

kodiakhq bot deleted the bugfix/server-content-hash branch May 19, 2021 18:44

nickrttn mentioned this pull request May 20, 2021

Latest version of [email protected] broke the build using next-plugin-preact preactjs/next-plugin-preact#31

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021

server doesn't need to be contenthashing at all (vercel#25251)

30cb964

contenthashing is not useful for the server cc @ijjk

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server doesn't need to be contenthashing at all #25251

server doesn't need to be contenthashing at all #25251

sokra commented May 19, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented May 19, 2021

ijjk commented May 19, 2021

server doesn't need to be contenthashing at all #25251

server doesn't need to be contenthashing at all #25251

Conversation

sokra commented May 19, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented May 19, 2021

Failing test suites

ijjk commented May 19, 2021

Stats from current PR

sokra commented May 19, 2021 •

edited

Loading