Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for async next.config.js function #23012

Closed
wants to merge 1 commit into from
Closed

feat: add support for async next.config.js function #23012

wants to merge 1 commit into from

Conversation

alexandernanberg
Copy link
Contributor

Fixes #21369, #21674, #12097

Where would be the best place to add the test? tests/integration/config?

@ijjk
Copy link
Member

ijjk commented Mar 12, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
buildDuration 9.8s 10s ⚠️ +147ms
nodeModulesSize 42.8 MB 42.8 MB -251 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.843 1.836 -0.01
/ avg req/sec 1356.71 1361.84 +5.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.046 1.07 ⚠️ +0.02
/error-in-render avg req/sec 2390.09 2335.59 ⚠️ -54.5
Client Bundles (main, webpack, commons)
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c0d2c96..de48.js gzip 1.67 kB 1.67 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
index.html gzip 611 B 611 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
buildDuration 11.6s 11.6s ⚠️ +6ms
nodeModulesSize 42.8 MB 42.8 MB -251 B
Client Bundles (main, webpack, commons)
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c0d2c96..de48.js gzip 1.67 kB 1.67 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
buildDuration 11.6s 11.7s ⚠️ +180ms
nodeModulesSize 42.8 MB 42.8 MB -251 B
Page Load Tests Overall increase ✓
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.811 1.77 -0.04
/ avg req/sec 1380.22 1412.44 +32.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.162 1.086 -0.08
/error-in-render avg req/sec 2150.72 2301.45 +150.73
Client Bundles (main, webpack, commons)
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_app-0c62a59..94b7.js gzip 1.26 kB 1.26 kB ✓
_error-97d24..ed28.js gzip 3.38 kB 3.38 kB ✓
amp-2926e4c2..9ccc.js gzip 536 B 536 B ✓
hooks-1ed65b..8908.js gzip 902 B 902 B ✓
index-6259b6..77d8.js gzip 230 B 230 B ✓
link-b722682..14a4.js gzip 1.65 kB 1.65 kB ✓
routerDirect..862a.js gzip 306 B 306 B ✓
withRouter-4..76fd.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary alexandernanberg/next.js an/feat/async-config Change
index.html gzip 585 B 585 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ycUis2khAg3mjkcmutybk",
+        "buildId": "2d_hq38uraSdGLM8jAOIw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ycUis2khAg3mjkcmutybk/_buildManifest.js"
+      src="/_next/static/2d_hq38uraSdGLM8jAOIw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ycUis2khAg3mjkcmutybk/_ssgManifest.js"
+      src="/_next/static/2d_hq38uraSdGLM8jAOIw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ycUis2khAg3mjkcmutybk",
+        "buildId": "2d_hq38uraSdGLM8jAOIw",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ycUis2khAg3mjkcmutybk/_buildManifest.js"
+      src="/_next/static/2d_hq38uraSdGLM8jAOIw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ycUis2khAg3mjkcmutybk/_ssgManifest.js"
+      src="/_next/static/2d_hq38uraSdGLM8jAOIw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ycUis2khAg3mjkcmutybk",
+        "buildId": "2d_hq38uraSdGLM8jAOIw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ycUis2khAg3mjkcmutybk/_buildManifest.js"
+      src="/_next/static/2d_hq38uraSdGLM8jAOIw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ycUis2khAg3mjkcmutybk/_ssgManifest.js"
+      src="/_next/static/2d_hq38uraSdGLM8jAOIw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 09fa40c

@alexandernanberg
Copy link
Contributor Author

alexandernanberg commented Mar 31, 2021 •
edited
Loading

Just saw #22153, which would remove for this PR. Since you can do top-level await's in esm

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandernanberg @ijjk