Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AMP Optimizer to v2.5.2 #14095

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Update AMP Optimizer to v2.5.2 #14095

merged 2 commits into from
Jun 11, 2020

Conversation

sebastianbenz
Copy link
Contributor

This addresses the problem of the optimizer postinstall hook causing
delayed installs if run behind a proxy. See ampproject/amp-toolbox#832

Fixes #14070

@sebastianbenz
Update AMP Optimizer to v2.5.2
78f69e6 
This addresses the problem of the optimizer postinstall hook causing
delayed installs if run behind a proxy. See ampproject/amp-toolbox#832

Fixes vercel#14070
@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
buildDuration 11.4s 11.4s ⚠️ +79ms
nodeModulesSize 64.9 MB 65.2 MB ⚠️ +268 kB
Page Load Tests Overall increase ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.992 1.909 -0.08
/ avg req/sec 1254.82 1309.4 ⚠️ +54.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.29 1.314 ⚠️ +0.02
/error-in-render avg req/sec 1937.28 1903.12 -34.16
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
buildDuration 12.5s 12.1s -486ms
nodeModulesSize 64.9 MB 65.2 MB ⚠️ +268 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
buildDuration 12.3s 11.9s -342ms
nodeModulesSize 64.9 MB 65.2 MB ⚠️ +268 kB
Page Load Tests Overall increase ✓
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.214 2.046 -0.17
/ avg req/sec 1129.2 1221.9 ⚠️ +92.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.344 1.294 -0.05
/error-in-render avg req/sec 1860.05 1931.58 ⚠️ +71.53
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
buildDuration 13.1s 12.8s -274ms
nodeModulesSize 64.9 MB 65.2 MB ⚠️ +268 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary sebastianbenz/next.js amp-optimizer-2.5.2 Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@kodiakhq kodiakhq bot merged commit ec90cc8 into vercel:canary Jun 11, 2020
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this pull request Jun 12, 2020
@sebastianbenz @darshkpatel
Update AMP Optimizer to v2.5.2 (vercel#14095)
7cb898c 
This addresses the problem of the optimizer postinstall hook causing
delayed installs if run behind a proxy. See ampproject/amp-toolbox#832

Fixes vercel#14070
@ndom91 ndom91 mentioned this pull request Jun 22, 2020
Closed
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@sebastianbenz @rokinsky
Update AMP Optimizer to v2.5.2 (vercel#14095)
13c4f29 
This addresses the problem of the optimizer postinstall hook causing
delayed installs if run behind a proxy. See ampproject/amp-toolbox#832

Fixes vercel#14070
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

installing nextjs behind a proxy takes a long time and prints errors in the console
3 participants
@sebastianbenz @ijjk @timneutkens