Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Avatar.js component where Strapi CMS would fail when fetching an image #14084

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

M1ck0
Copy link
Contributor

@M1ck0 M1ck0 commented Jun 11, 2020

I tried creating CMS with Strapi by following this README.MD. After configuring everything I noticed that app isn't working.

This is error that occured on yarn dev

image

After logging data that is sent to <Avatar/> component I noticed that picture is actually an Array.

image

After modifying code bellow everything works as it should and CMS works properly.

@ijjk ijjk added the examples Issue/PR related to examples label Jun 11, 2020
@M1ck0 M1ck0 changed the title Fixed Avatar.js component where it would fail when fetching an image Fixed Avatar.js component where it CMS would fail when fetching an image Jun 11, 2020
@M1ck0 M1ck0 changed the title Fixed Avatar.js component where it CMS would fail when fetching an image Fixed Avatar.js component where Strapi CMS would fail when fetching an image Jun 11, 2020
@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
buildDuration 12.4s 12.6s ⚠️ +190ms
nodeModulesSize 64.9 MB 64.9 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
/ failed reqs 0 0
/ total time (seconds) 2.154 2.155 0
/ avg req/sec 1160.44 1160.09 -0.35
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.429 ⚠️ +0.01
/error-in-render avg req/sec 1756.88 1749.84 -7.04
Client Bundles (main, webpack, commons)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.js gzip 6.49 kB 6.49 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.module.js gzip 5.58 kB 5.58 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
Overall change 8.22 kB 8.22 kB
Client Pages Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 275 B 275 B
Overall change 545 B 545 B
Rendered Page Sizes
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.html gzip 954 B 954 B
link.html gzip 961 B 961 B
withRouter.html gzip 947 B 947 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
buildDuration 13.5s 13.4s -150ms
nodeModulesSize 64.9 MB 64.9 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.js gzip 6.49 kB 6.49 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.module.js gzip 5.58 kB 5.58 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
Overall change 8.22 kB 8.22 kB
Client Pages Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 275 B 275 B
Overall change 545 B 545 B
Serverless bundles
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_error.js 875 kB 875 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 875 kB 875 kB
link.js 913 kB 913 kB
routerDirect.js 905 kB 905 kB
withRouter.js 905 kB 905 kB
Overall change 4.48 MB 4.48 MB

@lfades
Copy link
Member

lfades commented Jun 11, 2020

@M1ck0 Can you please confirm that there's no case where the picture may not be an array? 🤔

@Timer
Copy link
Member

Timer commented Jun 11, 2020

Maybe we can do picture[0] ?? picture to handle both

@M1ck0
Copy link
Contributor Author

M1ck0 commented Jun 11, 2020

As far as I tested it is Array in every case (I tried making CMS from scratch few more times).

@chibicode
Copy link
Member

chibicode commented Jun 11, 2020

Hi @M1ck0, could you double-check that you chose Single media instead of Multiple media when setting up the Author collection?

Screen Shot 2020-06-11 at 2 31 57 PM

This was mentioned on README:

Media field called picture (Single media)

Copy link
Member

@chibicode chibicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @Timer said sounds fine - could you implement this so it can handle both cases?

Maybe we can do picture[0] ?? picture to handle both

@M1ck0
Copy link
Contributor Author

M1ck0 commented Jun 11, 2020

You were right @chibicode . I checked multiple media, my bad. I also added checks for both outcomes now as @Timer suggested.

@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
buildDuration 12s 12.2s ⚠️ +237ms
nodeModulesSize 65.2 MB 65.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
/ failed reqs 0 0
/ total time (seconds) 2.014 1.97 -0.04
/ avg req/sec 1241.13 1269.11 ⚠️ +27.98
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.198 1.185 -0.01
/error-in-render avg req/sec 2087.11 2110.36 ⚠️ +23.25
Client Bundles (main, webpack, commons)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.js gzip 6.49 kB 6.49 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.module.js gzip 5.58 kB 5.58 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
Overall change 8.22 kB 8.22 kB
Client Pages Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 275 B 275 B
Overall change 545 B 545 B
Rendered Page Sizes
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.html gzip 954 B 954 B
link.html gzip 961 B 961 B
withRouter.html gzip 947 B 947 B
Overall change 2.86 kB 2.86 kB

Serverless Mode
General
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
buildDuration 13.1s 12.8s -297ms
nodeModulesSize 65.2 MB 65.2 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.js gzip 6.49 kB 6.49 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.module.js gzip 5.58 kB 5.58 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
Overall change 8.22 kB 8.22 kB
Client Pages Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 275 B 275 B
Overall change 545 B 545 B
Serverless bundles
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_error.js 875 kB 875 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 875 kB 875 kB
link.js 913 kB 913 kB
routerDirect.js 905 kB 905 kB
withRouter.js 905 kB 905 kB
Overall change 4.48 MB 4.48 MB

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Jun 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
buildDuration 12.2s 12.3s ⚠️ +24ms
nodeModulesSize 65.2 MB 65.2 MB
Page Load Tests Overall increase ✓
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
/ failed reqs 0 0
/ total time (seconds) 2.13 2.193 ⚠️ +0.06
/ avg req/sec 1173.79 1140.04 -33.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.443 1.404 -0.04
/error-in-render avg req/sec 1732.73 1780.73 ⚠️ +48
Client Bundles (main, webpack, commons)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.js gzip 6.51 kB 6.51 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.module.js gzip 5.6 kB 5.6 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
_error.js gzip 3.37 kB 3.37 kB
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
Overall change 8.34 kB 8.34 kB
Client Pages Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
hooks.module.js gzip 383 B 383 B
_error.module.js gzip 2.21 kB 2.21 kB
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.49 kB 5.49 kB
Client Build Manifests
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 274 B 274 B
Overall change 544 B 544 B
Rendered Page Sizes
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.html gzip 957 B 957 B
link.html gzip 963 B 963 B
withRouter.html gzip 951 B 951 B
Overall change 2.87 kB 2.87 kB

Serverless Mode
General
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
buildDuration 13.1s 12.8s -273ms
nodeModulesSize 65.2 MB 65.2 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.js gzip 6.51 kB 6.51 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
main-HASH.module.js gzip 5.6 kB 5.6 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
_error.js gzip 3.37 kB 3.37 kB
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
Overall change 8.34 kB 8.34 kB
Client Pages Modern
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
hooks.module.js gzip 383 B 383 B
_error.module.js gzip 2.21 kB 2.21 kB
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.49 kB 5.49 kB
Client Build Manifests
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 274 B 274 B
Overall change 544 B 544 B
Serverless bundles
vercel/next.js canary M1ck0/next.js cms-strapi-fix Change
_error.js 875 kB 875 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 875 kB 875 kB
link.js 913 kB 913 kB
routerDirect.js 905 kB 905 kB
withRouter.js 905 kB 905 kB
Overall change 4.48 MB 4.48 MB

@lfades lfades dismissed chibicode’s stale review June 12, 2020 01:39

Updated based on requested changes.

@kodiakhq kodiakhq bot merged commit f343410 into vercel:canary Jun 12, 2020
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this pull request Jun 12, 2020
…n image (vercel#14084)

I tried creating CMS with ```Strapi``` by following [this README.MD](https://github.com/M1ck0/next.js/tree/canary/examples/cms-strapi). After configuring everything I noticed that app isn't working.

This is error that occured on ```yarn dev```

![image](https://user-images.githubusercontent.com/19279947/84417177-8d1cff80-ac15-11ea-942a-4acf9b9b8bcb.png)

After logging data that is sent to ```<Avatar/>``` component I noticed that ```picture``` is actually an ```Array```.

![image](https://user-images.githubusercontent.com/19279947/84417337-c05f8e80-ac15-11ea-9cf5-a6890bc1744b.png)

After modifying code bellow everything works as it should and CMS works properly.
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
…n image (vercel#14084)

I tried creating CMS with ```Strapi``` by following [this README.MD](https://github.com/M1ck0/next.js/tree/canary/examples/cms-strapi). After configuring everything I noticed that app isn't working.

This is error that occured on ```yarn dev```

![image](https://user-images.githubusercontent.com/19279947/84417177-8d1cff80-ac15-11ea-942a-4acf9b9b8bcb.png)

After logging data that is sent to ```<Avatar/>``` component I noticed that ```picture``` is actually an ```Array```.

![image](https://user-images.githubusercontent.com/19279947/84417337-c05f8e80-ac15-11ea-9cf5-a6890bc1744b.png)

After modifying code bellow everything works as it should and CMS works properly.
@M1ck0 M1ck0 deleted the cms-strapi-fix branch December 9, 2020 13:13
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants