-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint randomly started enforcing new rule which is incorrect and breaking my builds #40245
Comments
See my comments on the eslint issue; this should be closed as it's an issue with eslint-plugin-react (which has been fixed). See jsx-eslint/eslint-plugin-react#3380. eslint-config-next surely uses |
@ljharb this shouldn't be closed, as |
yeah @JDansercoer @ljharb looks like I will keep the issue open until my |
That’s not how transitive deps work. The next config is using ^ to depend on the react plugin, so you already updated it beyond v7.29.4, just not far enough to include the fixed version. It’s on you to update it farther. |
What should be done about #40269, which flags |
As @ljharb suggests, this is not a Next.js issue, so I'll close it. You just have to make sure that your dependencies are up-to-date. As for |
`eslint-plugin-react` has a broken version between v7.31.2-6. Upping the version range ensure that only functioning packages get installed. Fixes #40245 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Co-authored-by: JJ Kasper <[email protected]>
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
Node version:
v16.15.1
npm version:
8.19.0
Local ESLint version:
8.23.0
Global ESLint version:
N/A
Operating System:
macOS Big Sur / M1 Mac
What browser are you using? (if relevant)
N/A
How are you deploying your application? (if relevant)
Vercel
Describe the Bug
ESLint is enforcing a rule which is breaking my build.
I went through my old vercel builds and found where it stopped working—I updated some packages and that was it. I just tried to revert back to all the old package versions where the builds were working fine and I still am getting the errors now.
I'm not sure why ESLint decided to enforce this rule randomly or why it's throwing an error even though it's a real property. I know I can ignore it with next.js configs but I'm instead trying to figure out what's happening here.
I also have an identical personal portfolio project with the same setup code and up-to-date packages in which I'm not having this issue. I can't understand why it's only happening on this repo.
If you have any ideas as to what's happening please let me know, thank you.
I have made an issue over at ESLint's repo too as I'm not sure which would be more appropriate.
Expected Behavior
Builds should pass.
Link to reproduction
https://github.com/tr1s/nightizm
To Reproduce
Run
npm run lint
and see that these errors are showing up. They shouldn't be showing up at all.The text was updated successfully, but these errors were encountered: