-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSC: shared components using next built-in components doesn't work #35449
Comments
huozhi
added
bug
Issue was opened via the bug report template.
kind: bug
and removed
bug
Issue was opened via the bug report template.
labels
Mar 19, 2022
3 tasks
kodiakhq bot
pushed a commit
that referenced
this issue
Apr 7, 2022
Fixes #35449 Include the shared components (from source code) is in client bundles, previously we lost them so that the client components imported by them are lost in module graph * let flight server loader apply to all pages and imported modules (except node_modules at the moment) * if it's a shared component from source code, include it in client bundle * ignore handling node_modules at the moment (due to the limitation support of esm imports with RSC) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md`
colinhacks
pushed a commit
to colinhacks/next.js
that referenced
this issue
Apr 14, 2022
…#35975) Fixes vercel#35449 Include the shared components (from source code) is in client bundles, previously we lost them so that the client components imported by them are lost in module graph * let flight server loader apply to all pages and imported modules (except node_modules at the moment) * if it's a shared component from source code, include it in client bundle * ignore handling node_modules at the moment (due to the limitation support of esm imports with RSC) ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md`
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Verify canary release
Provide environment information
What browser are you using? (if relevant)
Chrome 99
How are you deploying your application? (if relevant)
No response
Describe the Bug
Sample App
Seeing error
Other clues
Flight manifest doesn't contain the reference of
next/link
as expected.Expected Behavior
Should render the link and be able to interact with, since
next/link
should be treated as client componentsTo Reproduce
next dev
localhost:3000
The text was updated successfully, but these errors were encountered: