Skip to content

fix(perf): use swc for minify #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SukkaW wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(perf): use swc for minify #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1db7c46
perf: use swc
SukkaW Mar 13, 2025
02e95a4
chore: update test case
SukkaW Mar 13, 2025
3ad9bc4
chore: update swc to the latest version
SukkaW Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
"source-map-support": "^0.5.9",
"stripe": "^8.167.0",
"swig": "^1.4.2",
"terser": "^5.33.0",
"the-answer": "^1.0.0",
"tiny-json-http": "^7.5.1",
"ts-loader": "^9.4.4",
Expand All @@ -109,5 +108,8 @@
"webpack": "5.94.0",
"when": "^3.7.8"
},
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"dependencies": {
"@swc/wasm": "^1.11.20"
}
}
3 changes: 2 additions & 1 deletion scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async function main() {
__dirname + "/../src/cli",
{
filename: "cli.js",
externals: ["./index.js"],
externals: ["./index.js", "@swc/wasm"],
license: 'LICENSES.txt',
minify,
cache,
Expand All @@ -32,6 +32,7 @@ async function main() {
__dirname + "/../src/index",
{
filename: "index.js",
externals: ["@swc/wasm"],
minify,
cache,
v8cache
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const crypto = require("crypto");
const { join, dirname, extname, resolve: pathResolve } = require("path");
const webpack = require("webpack");
const MemoryFS = require("memory-fs");
const terser = require("terser");
const { minify: swcMinify } = require("@swc/wasm");
const tsconfigPaths = require("tsconfig-paths");
const { loadTsconfig } = require("tsconfig-paths/lib/tsconfig-loader");
const TsconfigPathsPlugin = require("tsconfig-paths-webpack-plugin");
Expand Down Expand Up @@ -475,7 +475,7 @@ function ncc (
if (minify) {
let result;
try {
result = await terser.minify(code, {
result = await swcMinify(code, {
module: esm,
compress: false,
mangle: {
Expand Down
2 changes: 1 addition & 1 deletion test/unit/minify-err/output.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/unit/minify-sourcemap-register/output.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/unit/minify-v8cache-sourcemap-register/output.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/unit/minify/output.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,6 +1693,11 @@
dependencies:
tslib "^2.4.0"

"@swc/wasm@^1.11.20":
version "1.11.20"
resolved "https://registry.yarnpkg.com/@swc/wasm/-/wasm-1.11.20.tgz#124476f92dacb3a29a77a2038c77d3d4ebebe188"
integrity sha512-U8GG2jCxESlGiprOHwu097e6DzN5F4v5yKVBmk9/iEEJj0TYFv/l0bf+upocEYFvy+XMnVdvNlUfWZBG/og71Q==

"@szmarczak/http-timer@^1.1.2":
version "1.1.2"
resolved "https://registry.yarnpkg.com/@szmarczak/http-timer/-/http-timer-1.1.2.tgz#b1665e2c461a2cd92f4c1bbf50d5454de0d4b421"
Expand Down Expand Up @@ -14263,7 +14268,7 @@ terser-webpack-plugin@^5.3.10:
serialize-javascript "^6.0.1"
terser "^5.26.0"

terser@^5.26.0, terser@^5.33.0:
terser@^5.26.0:
version "5.33.0"
resolved "https://registry.yarnpkg.com/terser/-/terser-5.33.0.tgz#8f9149538c7468ffcb1246cfec603c16720d2db1"
integrity sha512-JuPVaB7s1gdFKPKTelwUyRq5Sid2A3Gko2S0PncwdBq7kN9Ti9HPWDQ06MPsEDGsZeVESjKEnyGy68quBk1w6g==
Expand Down
Loading