Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotkey for windows explorer context menu entry #7118

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

LeannAlexandra
Copy link
Contributor

Added the ampersand to the registry entry to give it the shortcut of "H" in windows. - in short Shift+F10 gives advanced options and "Open Hyper here now has the the H underlined and marked as hotkey. This is a small feature -I already manually found and updated the registry entries on my desktop and thought this is a small touch that adds just that bit more trust to the project. The others in the illustration below are marked at install.

This PR is ready to be merged. - everything is done.

hyper3

and proof that it is running on my personal computer with no bugs.
regedit_s78FznwmwO

Added the ampersand to the registry entry to give it the shortcut of "H" in windows. - in short Shift+F10 gives advanced options and "Open Hyper here now has the the H underlined and marked as hotkey.
@LabhanshAgrawal LabhanshAgrawal changed the title Update installer.nsh Add hotkey for windows explorer context menu entry Apr 10, 2023
@github-actions
Copy link

Hi there,
Thank you for contributing to Hyper!
You can get the build artifacts from here.
Here are screenshots of Hyper built from this pr.
Imgur ImagesImgur Images

@LabhanshAgrawal
Copy link
Collaborator

LabhanshAgrawal commented Apr 10, 2023

Neat, thanks for the contribution. I don't have access to my windows device this week, so can't test it myself for now. But it should be ok. Please install using the installer from this pr and confirm if it's working for you, then it should be good to merge.

@LeannAlexandra
Copy link
Contributor Author

LeannAlexandra commented Apr 10, 2023 via email

@LabhanshAgrawal
Copy link
Collaborator

Can't see the recording. I guess github doesn't support attachments from email, you might need to add it to comment manually.

@LeannAlexandra
Copy link
Contributor Author

Sorry about that - here is the Video:

NVIDIA_Share_BI9Ed19qeP.mp4

@LabhanshAgrawal
Copy link
Collaborator

looks good

@LabhanshAgrawal LabhanshAgrawal merged commit 8645e0f into vercel:canary Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants