Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for displaying Sixels #6987

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Add support for displaying Sixels #6987

merged 6 commits into from
Jun 16, 2023

Conversation

marvinruder
Copy link
Contributor

@marvinruder marvinruder commented Jan 16, 2023

Closes #6748

For a quick demo, run curl https://raw.githubusercontent.com/saitoha/libsixel/master/images/snake.six

@LabhanshAgrawal
Copy link
Collaborator

Thanks for your contribution, I'll test it out soon.
From what I read, the addon is in beta and does not work with the latest xterm version (we're not on latest right now, but I'm working on that currently). So, it might be better to make it as a plugin instead, will have to take a deeper look to decide.

@marvinruder
Copy link
Contributor Author

The add-on claims compatibility with xterm.js 5.1.0, which is the current stable release, but I tried it out with 5.2.0 beta and it still works there. I am open to a plug-in solution, if adding an xterm add-on is supported by one of Hyper’s extension APIs (I am not too familiar with those, but will have a look later). If not, we could also add a boolean variable to the configuration JSON for enabling/disabling the add-on.

@LabhanshAgrawal
Copy link
Collaborator

Oh, I saw jerch/xterm-addon-image#38 , didn't know it's fixed.

@marvinruder
Copy link
Contributor Author

If a plug-in solution is favored, xterm.js’ loadAddon method would likely need to be exposed to plug-ins, as requested in #4560.

@jessebot
Copy link

@marvinruder and @LabhanshAgrawal thanks for your efforts on this. Really looking forward to this feature :)

@jerch
Copy link

jerch commented Jan 29, 2023

Oh, I saw jerch/xterm-addon-image#38 , didn't know it's fixed.

Ah sorry, forgot to close the issue along with the fix.

lib/components/term.tsx Outdated Show resolved Hide resolved
@jerch
Copy link

jerch commented Feb 22, 2023

Minor headsup - just added iTerm IIP support in the addon, though I consider it alpha (cannot really test&compare against iTerm2).

@LabhanshAgrawal
Copy link
Collaborator

Sorry, I was caught up with things, have to rethink the pr on xterm's repo for ligature fix as well, I'm thinking to merge this (with xterm v5) in the coming days, even if the ligature fix is not there yet, as anyways ligatures are disabled on electron in xterm v5 currently, so we can have few canary releases without ligatures, and then work on that instead of blocking this.
Thanks

@LabhanshAgrawal
Copy link
Collaborator

I've upgraded xterm to v5, please rebase.

@LabhanshAgrawal
Copy link
Collaborator

great work @marvinruder, also thanks @jerch for the awesome addon and your support on this pr.
Everything's looking good on local testing, just waiting for the CI.
Screenshot 2023-06-16 at 17 35 04

@github-actions
Copy link

Hi there,
Thank you for contributing to Hyper!
You can get the build artifacts from here.
Here are screenshots of Hyper built from this pr.
Imgur ImagesImgur Images

@LabhanshAgrawal LabhanshAgrawal merged commit 95807fa into vercel:canary Jun 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to display images inline in terminal?
4 participants