Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flicks after a full reload or when close tab button (dis)appear. (Fix #1490, #1575, #1579) #1602

Merged
merged 2 commits into from
Mar 5, 2017

Conversation

chabou
Copy link
Collaborator

@chabou chabou commented Mar 5, 2017

This PR fixes #1490.

Adding -webkit-backface-visibility: hidden does the trick. I didn't notice any perf issue after adding it.
Adding it to main body or iframe body does the trick too. But I think it is better to colocate the trick with the incriminated transition.

@chabou chabou changed the title Fix color text flick in term when close tab button (dis)appear. (Fix #1490) Fix flicks after a full reload or when close tab button (dis)appear. (Fix #1490, #1575, #1579) Mar 5, 2017
@chabou
Copy link
Collaborator Author

chabou commented Mar 5, 2017

Ok! put -webkit-backface-visibility: hidden on main body fixes flick after a full reload too (#1575 and #1579) 🎉

@matheuss
Copy link
Member

matheuss commented Mar 5, 2017

amazing

@matheuss matheuss merged commit 1f3ea08 into vercel:master Mar 5, 2017
@chabou chabou deleted the fix_transition_flick branch March 5, 2017 19:09
tylerong pushed a commit to tylerong/hyper that referenced this pull request Jul 3, 2017
…ix vercel#1490, vercel#1575, vercel#1579) (vercel#1602)

* Fix term text flick when mouse is hovering tab

* Fix flick issue after a full reload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants