Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/track: always consume the response body for a track request #131

Merged
merged 2 commits into from
Feb 15, 2024
Merged

server/track: always consume the response body for a track request #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b306e98
server/track: always consume the response body for a track requeest
MaxLeiter Feb 15, 2024
596dab0
Bump package version
MaxLeiter Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vercel/analytics",
"version": "1.1.3",
"version": "1.1.4",
"description": "Gain real-time traffic insights with Vercel Web Analytics",
"keywords": [
"analytics",
Expand Down
18 changes: 11 additions & 7 deletions packages/web/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,17 @@ export async function track(
},
body: JSON.stringify(body),
method: 'POST',
}).catch((err: unknown) => {
if (err instanceof Error && 'response' in err) {
console.error(err.response);
} else {
console.error(err);
}
});
})
// We want to always consume to body; some cloud providers track fetch concurrency
// and may not release the connection until the body is consumed.
.then((response) => response.text())
.catch((err: unknown) => {
if (err instanceof Error && 'response' in err) {
console.error(err.response);
} else {
console.error(err);
}
});

if (requestContext?.waitUntil) {
requestContext.waitUntil(promise);
Expand Down
Loading