fix (provider/bedrock): support budgetTokens #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually don't know if I did the changeset correctly for this. |
lgrammel
reviewed
Mar 6, 2025
|
docs needs no changeset (only pkg releases) |
…okens in provider options tweak(docs/amazon-bedrock): Standardize on budgetTokens in amazon docs to reflect anthropic tweak(examples/amazon-bedrock): Standarize on budgetTokens
lgrammel
reviewed
Mar 6, 2025
Comment on lines
581
to
595
| .transform(data => { | ||
| if (!data) return data; | ||
|
|
||
| // Normalize the data to ensure we have budget_tokens | ||
| if (data.budgetTokens !== undefined && data.budget_tokens === undefined) { | ||
| return { | ||
| ...data, | ||
| budget_tokens: data.budgetTokens, | ||
| // Remove budgetTokens to avoid duplication | ||
| budgetTokens: undefined, | ||
| }; | ||
| } | ||
|
|
||
| return data; | ||
| }); |
There was a problem hiding this comment.
can this be solved in the thinking budget definition instead of having a transform (line 131)
There was a problem hiding this comment.
Yeah let me try that
There was a problem hiding this comment.
My hesitation here is that if I do:
const BedrockReasoningConfigOptionsSchema = z
.object({
type: z.union([z.literal('enabled'), z.literal('disabled')]),
})
.and(
z.union([
z.object({ budget_tokens: z.number() }),
z.object({ budgetTokens: z.number() }),
])
)
.nullish();Instead of the transform, it will break type checking here:
const thinkingBudget = reasoningConfigOptions.data?.budget_tokens ??
reasoningConfigOptions.data?.budgetTokens;I can fix that using in, but doesn't seem as clean?
e.g.
const thinkingBudget = reasoningConfigOptions.data &&
('budget_tokens' in reasoningConfigOptions.data
? reasoningConfigOptions.data.budget_tokens
: 'budgetTokens' in reasoningConfigOptions.data
? reasoningConfigOptions.data.budgetTokens
: undefined);I pushed that in: 35cf123
There was a problem hiding this comment.
attempt to simplify: #5093
Und3rf10w
changed the title
budgetTokens
lgrammel
changed the title
budgetTokens
lgrammel
reviewed
Mar 6, 2025
lgrammel
reviewed
Mar 6, 2025
lgrammel
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds backwards compatibility to support specifying
budgetTokensin reasoning config for amazon-bedrock provider. This will be transformed tobudget_tokensbefore being sent to the model.