Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Endorsement and Evidence Plugin for Parsec CCA scheme #166

Merged
merged 1 commit into from
Jul 12, 2023
Merged

New Endorsement and Evidence Plugin for Parsec CCA scheme #166

merged 1 commit into from
Jul 12, 2023

Conversation

yogeshbdeshpande
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande commented Jun 20, 2023 •
edited
Loading

Fixes #171

@yogeshbdeshpande yogeshbdeshpande force-pushed the yd-parsec-cca branch 4 times, most recently from 6a82b48 to a0fcd66 Compare June 28, 2023 18:18
@yogeshbdeshpande yogeshbdeshpande changed the title [WIP] Initial skeleton New Endorsement and Evidence Plugin for Parsec CCA scheme Jun 28, 2023
@yogeshbdeshpande yogeshbdeshpande marked this pull request as ready for review June 28, 2023 18:31
setrofim
setrofim approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomas-fossati
thomas-fossati reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is now a lot of code duplicated from CCA which is not exactly great maintenance-wise. I wonder whether we could factor out the common parts in a arm/cca package?

policy/test/inputs/parsec-cca-evidence.json Outdated Show resolved Hide resolved
policy/test/inputs/parsec-cca-mismatch-evidence.json Outdated Show resolved Hide resolved
policy/test/inputs/parsec-cca-result.json Outdated Show resolved Hide resolved
scheme/README.md Outdated Show resolved Hide resolved
scheme/parsec-cca/evidence_handler.go Outdated
}

lookupKey := arm.RefValLookupKey(SchemeName, tenantID, implID)
log.Debug("PARSEC CCA Plugin Reference Value Look Up Key= %s\n", lookupKey)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and all the other debug statements below should use the formatted version of the API. (I'm having a dejavu about this, but I can't remember the details.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has not been addressed

scheme/parsec-cca/evidence_handler.go Outdated Show resolved Hide resolved
scheme/parsec-cca/evidence_handler.go Outdated Show resolved Hide resolved
scheme/parsec-cca/evidence_handler.go Outdated Show resolved Hide resolved
scheme/parsec-cca/evidence_handler.go Outdated
token.TenantId,
arm.MustImplIDString(parsecCca.Pat.PlatformClaims),
)
log.Debug("extracted Reference ID Key = %s", extracted.ReferenceID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto (use the formatting version)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has not been addressed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
Edited Issue #173 to handle this case and noticed a similar correction required in plugin for cca-ssd-platform.

Both plugins will be addressed by the above issue.

@yogeshbdeshpande
Copy link
Collaborator Author

yogeshbdeshpande commented Jul 11, 2023 •
edited
Loading

It looks like there is now a lot of code duplicated from CCA which is not exactly great maintenance-wise. I wonder whether we could factor out the common parts in a arm/cca package?

Any commonality between PSA/CCA and Parsec CCA has already been factored out. I will raise a separate github issue to factor out even further between the two schemes cca and parsec-cca.

@yogeshbdeshpande
Copy link
Collaborator Author

It looks like there is now a lot of code duplicated from CCA which is not exactly great maintenance-wise. I wonder whether we could factor out the common parts in a arm/cca package?

Any commonality between PSA/CCA and Parsec CCA has already been factored out. I will raise a separate github issue to factor out even further between the two schemes cca and parsec-cca.

See issue #173

@yogeshbdeshpande
Copy link
Collaborator Author

@thomas-fossati I am merging this after incorporating all review comments. This is to unblock provisioning plugin refactor activity. If at all any more comments ( will be addressed via issue #173 )

@yogeshbdeshpande yogeshbdeshpande merged commit 5a48655 into main Jul 12, 2023
@yogeshbdeshpande yogeshbdeshpande deleted the yd-parsec-cca branch July 12, 2023 23:19
@thomas-fossati
Copy link
Contributor

@thomas-fossati I am merging this after incorporating all review comments.

I have unresolved the comments that were resolved without being actually addressed.

This is to unblock provisioning plugin refactor activity. If at all any more comments ( will be addressed via issue #173 )

Merging to main is not the only way to unblock that activity: you could've branched off yd-parsec-cca...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati left review comments

@setrofim setrofim setrofim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Introduce New Verification and Endorsement Plugin for Parsec-CCA format
3 participants
@yogeshbdeshpande @thomas-fossati @setrofim