fix: deterministic encode cose_sign / cose_sign1 sig_signature #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 92.12% 92.48% +0.35%
==========================================
Files 10 10
Lines 978 1024 +46
==========================================
+ Hits 901 947 +46
- Misses 51 52 +1
+ Partials 26 25 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
shizhMSFT
requested review from
qmuntal,
thomas-fossati and
yogeshbdeshpande
Signed-off-by: Shiwei Zhang <[email protected]>
shizhMSFT
commented
Feb 20, 2023
Comment on lines
+118
to
+121
| case 27: | ||
| if data[1] != 0 || data[2] != 0 || data[3] != 0 || data[4] != 0 { | ||
| return data, nil | ||
| } |
There was a problem hiding this comment.
This path cannot be fully tested since it requires more than 4 GiB memory to test with, which is not allowed by GitHub Action.
There was a problem hiding this comment.
Captured the issue in #139
qmuntal
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #119