Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for paulmach/go.geojson #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 90 additions & 1 deletion geojsongeos/geojsongeos.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package geojsongeos
import (
"fmt"

pmgeojson "github.com/paulmach/go.geojson"
"github.com/paulsmith/gogeos/geos"
"github.com/venicegeo/geojson-go/geojson"
)
Expand All @@ -44,6 +45,94 @@ func GeosFromGeoJSON(input interface{}) (*geos.Geometry, error) {
switch gt := input.(type) {
case *geojson.Point:
geometry, err = geos.NewPoint(parseCoord(gt.Coordinates))
case *pmgeojson.Geometry:
switch gt.Type {
case pmgeojson.GeometryPoint:
geometry, err = geos.NewPoint(parseCoord(gt.Point))
case pmgeojson.GeometryLineString:
geometry, err = geos.NewLineString(parseCoordArray(gt.LineString)...)
case pmgeojson.GeometryPolygon:
var coords []geos.Coord
var coordsArray [][]geos.Coord
for inx := 0; inx < len(gt.Polygon); inx++ {
coords = parseCoordArray(gt.Polygon[inx])
coordsArray = append(coordsArray, coords)
}
geometry, err = geos.NewPolygon(coordsArray[0], coordsArray[1:]...)
case pmgeojson.GeometryMultiPoint:
var points []*geos.Geometry
var point *geos.Geometry
for jnx := 0; jnx < len(gt.MultiPoint); jnx++ {
point, err = geos.NewPoint(parseCoord(gt.MultiPoint[jnx]))
points = append(points, point)
}
geometry, err = geos.NewCollection(geos.MULTIPOINT, points...)
case pmgeojson.GeometryMultiLineString:
var lineStrings []*geos.Geometry
var lineString *geos.Geometry
for jnx := 0; jnx < len(gt.MultiLineString); jnx++ {
lineString, err = geos.NewLineString(parseCoordArray(gt.MultiLineString[jnx])...)
lineStrings = append(lineStrings, lineString)
}
geometry, err = geos.NewCollection(geos.MULTILINESTRING, lineStrings...)

case pmgeojson.GeometryCollection:
var (
geometries []*geos.Geometry
)
for _, collection := range gt.Geometries {
if geometry, err = GeosFromGeoJSON(collection); err != nil {
return nil, err
}
geometries = append(geometries, geometry)
}
if geometry, err = geos.NewCollection(geos.GEOMETRYCOLLECTION, geometries...); err != nil {
return nil, err
}

return geometry, nil
case pmgeojson.GeometryMultiPolygon:
var (
coords []geos.Coord
coordsArray [][]geos.Coord
polygons []*geos.Geometry
polygon *geos.Geometry
)
for _, polygonCoords := range gt.MultiPolygon {
coordsArray = nil
for _, ringCoords := range polygonCoords {
coords = parseCoordArray(ringCoords)
coordsArray = append(coordsArray, coords)
}
if polygon, err = geos.NewPolygon(coordsArray[0], coordsArray[1:]...); err != nil {
return nil, err
}
polygons = append(polygons, polygon)
}
if geometry, err = geos.NewCollection(geos.MULTIPOLYGON, polygons...); err != nil {
return nil, err
}
default:
err = fmt.Errorf("unexpected geometry type in GeosFromGeoJSON: %T", gt)
}
case *pmgeojson.Feature:
return GeosFromGeoJSON(gt.Geometry)
case *pmgeojson.FeatureCollection:
var (
geometries []*geos.Geometry
)
for _, feature := range gt.Features {
if geometry, err = GeosFromGeoJSON(feature); err != nil {
return nil, err
}
geometries = append(geometries, geometry)
}
if geometry, err = geos.NewCollection(geos.GEOMETRYCOLLECTION, geometries...); err != nil {
return nil, err
}

return geometry, nil

case *geojson.LineString:
geometry, err = geos.NewLineString(parseCoordArray(gt.Coordinates)...)
case *geojson.Polygon:
Expand Down Expand Up @@ -127,7 +216,7 @@ func GeosFromGeoJSON(input interface{}) (*geos.Geometry, error) {
case map[string]interface{}:
return GeosFromGeoJSON(geojson.FromMap(gt))
default:
err = fmt.Errorf("Unexpected type in GeosFromGeoJSON: %T\n", gt)
err = fmt.Errorf("unexpected type in GeosFromGeoJSON: %T", gt)
}
return geometry, err
}
Expand Down
52 changes: 52 additions & 0 deletions geojsongeos/geos_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,26 @@ limitations under the License.
package geojsongeos

import (
"encoding/json"
"io/ioutil"
"strings"
"testing"

pmgeojson "github.com/paulmach/go.geojson"
"github.com/paulsmith/gogeos/geos"
"github.com/venicegeo/geojson-go/geojson"
)

var inputGeometries = [...]string{
"test/point",
"test/linestring",
"test/polygon",
"test/multipoint",
"test/multilinestring",
"test/multipolygon",
"test/geometrycollection",
}

var inputGeojsonFiles2 = [...]string{
"test/point.geojson",
"test/linestring.geojson",
Expand All @@ -44,6 +56,46 @@ var inputWKTFiles = [...]string{
"test/multipolygon.wkt",
"test/geometryCollection.wkt"}

func TestPMGeoJSON(t *testing.T) {
var (
bytes []byte
err error
geometry *geos.Geometry
)
// Test all geojsonfiles on GeosFromGeoJSON
for inx, fileName := range inputGeometries {
var pmg pmgeojson.Geometry
if bytes, err = ioutil.ReadFile(fileName + ".geojson"); err == nil {
if err = json.Unmarshal(bytes, &pmg); err == nil {
geometry, err = GeosFromGeoJSON(&pmg)
t.Log(inx)
if wktbytes, err := ioutil.ReadFile(fileName + ".wkt"); err == nil {
if wktgeom, err := geos.FromWKT(string(wktbytes)); err == nil {
if eq, err := wktgeom.Equals(geometry); err == nil {
if !eq {
geometrywkt, _ := geometry.ToWKT()
if string(wktbytes) != geometrywkt {
t.Errorf("expected (%s), got (%s)", wktbytes, geometrywkt)
}
}
} else {
t.Error(err)
}
} else {
t.Error(err)
}
} else {
//t.Error(err)
}
} else {
t.Error(err)
}
} else {
t.Error(err)
}
}

}
func TestMain(t *testing.T) {
var (
bytes []byte
Expand Down
2 changes: 1 addition & 1 deletion geojsongeos/test/linestring.wkt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
LINESTRING (30 10, 10 30, 40 40)
LINESTRING (100 0, 101 1)