fix: symbol string size

[ethzoomer]

Closes #94

[ethzoomer]

Currently on this branch, a v2 pool containing a token with too large of a symbol returns "-NA-" for the pool symbol which is probably not ideal. Need to understand how to slice the response of the raw_call without making abi_decode() revert

[stas]

My understanding is that this should also be a String[192] if we're doing the max_outsize=192, no?

[ethzoomer]

The compiler only allows the string size to be a maximum of max_outsize - 64. But unfortunately there are cases where the raw_call spits out a response that is too large to fit into a string the size of max_outsize - 64

[stas]

@ethzoomer do you have a contract we can use to test this? I've simplified the conversion to be based on bytes btw, but would love to add a test before this is merged.

[ethzoomer]

@stas Ty good idea, this token was the one with the large symbol: 0x045D841ba37E180bC9b9D4da718E14b9ED7925d6. It can be fetched using LpSugar.tokens(1, 995)

[stas]

This should be up for review now.

Vyper doesn't let us have dynamic string size initialization. Because of this, we can't really use abi_decode() on an arbitrary size bytes array.

To avoid that, we basically ignore any bytes array larger than 96, meaning 10 chars. Larger token symbols will display as -???-.

[stas]

Reported the limitations upstream
vyperlang/vyper#4391

[ethzoomer]

@stas Verified here with tokens working, thank you!

all(1, 995) fails, I believe because symbol: staticcall pool.symbol(), needs to be a _safe_symbol() call. The 10 character limit may be too small for v2 pool symbols, do you have a preference for how to adjust this?

[stas]

all(1, 995) fails, I believe because symbol: staticcall pool.symbol(), needs to be a _safe_symbol() call.

good call o adding a test for the pool... I forgot the symbol 💩 will carry over there too!

The 10 character limit may be too small for v2 pool symbols, do you have a preference for how to adjust this?

I'll update the symbols to 30 chars

Ty ty for reviewing this!