feat: superchain #84
Merged
feat: superchain #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Looks great if these are all the changes we need to make!!! Love it!
My only concern is the factory registry. I think we need one even though it's for Sugar needs.
I think the registry, which we can deploy just once, is a much better way to avoid human errors. We've had enough issues where we'd forget to update the env vars here and end up with a bad release. So just trying to limit such an outcome!
contracts/LpSugar.vy
Outdated
| @@ -259,21 +259,23 @@ interface IAlmLpWrapper: | |||
|
|
|||
| # Vars | |||
| registry: public(IFactoryRegistry) | |||
| voter: public(IVoter) | |||
| voter: public(IVoter) # Voter on root , LeafVoter on leaf chain | |||
| factories: public(DynArray[address, MAX_FACTORIES]) | |||
There was a problem hiding this comment.
Would like to reconsider this direction.
scripts/deploy.py
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| def main(): | |||
| contract_name = str(os.getenv('CONTRACT')).lower() | |||
| chain_name = str(os.getenv('CHAIN')).upper() | |||
There was a problem hiding this comment.
Would like to switch to chain IDs instead. We do the same for web app.
Chane names are inconsistent and error prone.
Consider the format VOTER_${chain_id}=0x...0001 etc..
pedrovalido
force-pushed
the
feat/superchain-sugar
branch
3 times, most recently
from
1784b81 to
3ce3cc2
Compare
pedrovalido
force-pushed
the
feat/superchain-sugar
branch
from
3ce3cc2 to
a4e9691
Compare
stas
changed the title
🔴
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.