Skip to content

fix: wrap guardian notification in try-catch #9641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NgoHarrison merged 1 commit into from
Feb 26, 2026
Merged

fix: wrap guardian notification in try-catch #9641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions assistant/src/runtime/routes/inbound-message-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,14 +275,18 @@ export async function handleChannelInbound(
// Notify the guardian about the access request so they can approve/deny.
// Only fires when a guardian binding exists and no duplicate pending
// request already exists for this requester.
notifyGuardianOfAccessRequest({
canonicalAssistantId,
sourceChannel,
externalChatId,
senderExternalUserId: body.senderExternalUserId,
senderName: body.senderName,
senderUsername: body.senderUsername,
});
try {
notifyGuardianOfAccessRequest({
canonicalAssistantId,
sourceChannel,
externalChatId,
senderExternalUserId: body.senderExternalUserId,
senderName: body.senderName,
senderUsername: body.senderUsername,
});
} catch (err) {
log.error({ err, sourceChannel, externalChatId }, 'Failed to notify guardian of access request');
}

return Response.json({ accepted: true, denied: true, reason: 'not_a_member' });
}
Expand Down