Skip to content

fix(macos): improve refresh button UX on Connect status rows #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noanflaherty merged 1 commit into from
Feb 26, 2026
Merged

fix(macos): improve refresh button UX on Connect status rows #9321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions clients/macos/vellum-assistant/Features/Settings/SettingsConnectTab.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ struct SettingsConnectTab: View {
@State private var countdownTimer: Timer?
@State private var countdownTimerRefCount: Int = 0

// Refresh button minimum-spin state (keyed by row label)
@State private var refreshSpinning: Set<String> = []

// Token regeneration state
@State private var isRegeneratingToken: Bool = false

Expand Down Expand Up @@ -1823,7 +1826,9 @@ struct SettingsConnectTab: View {
lastChecked: Date? = nil,
onRefresh: (() -> Void)? = nil
) -> some View {
HStack(spacing: VSpacing.sm) {
let spinning = isRefreshing || refreshSpinning.contains(label)

return HStack(spacing: VSpacing.sm) {
Text(label)
.font(VFont.bodyMedium)
.foregroundColor(VColor.textSecondary)
Expand All @@ -1837,30 +1842,36 @@ struct SettingsConnectTab: View {
.font(VFont.body)
.foregroundColor(status.color)

Spacer()

if let onRefresh {
let tooltipText: String = {
if isRefreshing { return "Checking..." }
if spinning { return "Checking..." }
if let lastChecked { return "Last verified: \(relativeTimeString(from: lastChecked))" }
return "Test connection"
}()

Button {
if !isRefreshing { onRefresh() }
guard !spinning else { return }
refreshSpinning.insert(label)
onRefresh()
Task {
try? await Task.sleep(nanoseconds: 500_000_000)
refreshSpinning.remove(label)
}
} label: {
Image(systemName: "arrow.triangle.2.circlepath")
.font(.system(size: 11, weight: .medium))
.foregroundColor(isRefreshing ? VColor.accent : VColor.textMuted)
.rotationEffect(.degrees(isRefreshing ? 360 : 0))
.animation(isRefreshing ? .linear(duration: 1).repeatForever(autoreverses: false) : .default, value: isRefreshing)
.foregroundColor(spinning ? VColor.accent : VColor.textMuted)
.rotationEffect(.degrees(spinning ? 360 : 0))
.animation(spinning ? .linear(duration: 1).repeatForever(autoreverses: false) : .identity, value: spinning)
.frame(width: 24, height: 24)
.contentShape(Rectangle())
}
.buttonStyle(.plain)
.accessibilityLabel("Refresh \(label) status")
.help(tooltipText)
}

Spacer()
}
}

Expand Down