fix(macos): make entire heartbeat run row tappable#9256
Conversation
Replace Button with onTapGesture + contentShape(Rectangle()) so the full row area triggers expansion, not just the chevron icon. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b54197e56
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .onTapGesture { | ||
| withAnimation(VAnimation.fast) { | ||
| expandedRunId = expandedRunId == run.id ? nil : run.id | ||
| } | ||
| } |
There was a problem hiding this comment.
Replacing the Button with onTapGesture removes built-in control semantics, so this row is no longer keyboard-activatable or exposed as an actionable element to VoiceOver users. In the Settings list this turns expand/collapse into a pointer-only interaction for accessibility users, which is a functional regression from the previous implementation. Please keep a Button (and add .contentShape(Rectangle()) to its label) or explicitly restore equivalent accessibility role/action and keyboard activation behavior.
Useful? React with 👍 / 👎.
1 participant
Summary
ButtonwithonTapGesture+.contentShape(Rectangle())on the heartbeat run rowTest plan
🤖 Generated with Claude Code