Fix: M1 history pagination review feedback#9246
Merged
Merged
Conversation
…bility Co-Authored-By: Claude <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37f81475f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
Addressed in #9326 |
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback on #9227. Two issues fixed:
Default limit is now unlimited — When callers don't specify a
limit, all messages are returned (original behavior preserved). Previously, the default of 50 silently truncated history for existing callers that don't pass pagination params.Compound cursor for stable pagination — Added
beforeMessageIdas a tie-breaker alongsidebeforeTimestamp. When both are provided, the query useslte+neto include same-millisecond messages while excluding the boundary message already seen. Legacy callers withoutbeforeMessageIdfall back to strictlt(unchanged behavior).Implementation
getMessagesPaginated()now acceptslimit: number | undefined— whenundefined, returns all messages withhasMore: falsebeforeMessageIdparameter enables compound cursor:lte(createdAt, timestamp) AND ne(id, messageId)HistoryResponsenow includesoldestMessageIdalongsideoldestTimestampfor clients to use as the compound cursorFiles Changed
assistant/src/daemon/ipc-contract/sessions.ts— AddedbeforeMessageIdto request,oldestMessageIdto responseassistant/src/memory/conversation-store.ts— Unlimited support + compound cursor queryassistant/src/daemon/handlers/sessions.ts— Pass through new fields, default limit to undefinedclients/shared/IPC/Generated/IPCContractGenerated.swift— Regenerated from contract