Skip to content

fix: replace dead-branch MIME type ternary with lookup map #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 2 commits into from
Feb 25, 2026
Merged

fix: replace dead-branch MIME type ternary with lookup map #9049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4543ec
fix: replace dead-branch MIME type ternary with lookup map
Feb 25, 2026
88c7217
fix: use Map for MIME types to avoid prototype pollution
Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion assistant/src/daemon/handlers/recording.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ import { uploadFileBackedAttachment, linkAttachmentToMessage } from '../../memor
* from permanently blocking all future recordings. */
const STOP_ACK_TIMEOUT_MS = 30_000;

const RECORDING_MIME_TYPES = new Map<string, string>([
['mov', 'video/quicktime'],
['mp4', 'video/mp4'],
['webm', 'video/webm'],
]);

// ─── Deterministic maps ──────────────────────────────────────────────────────
// These ensure stop resolves the exact active recording for a conversation,
// prevent ambiguous cross-thread stop behavior, and maintain conversation
Expand Down Expand Up @@ -240,7 +246,7 @@ function handleRecordingStatus(

// Infer MIME type from extension
const ext = filename.split('.').pop()?.toLowerCase();
const mimeType = ext === 'mov' ? 'video/quicktime' : ext === 'mp4' ? 'video/mp4' : 'video/mp4';
const mimeType = (ext && RECORDING_MIME_TYPES.get(ext)) || 'video/mp4';

// Store as file-backed attachment (avoids reading large files into memory)
const attachment = uploadFileBackedAttachment(filename, mimeType, resolvedPath, sizeBytes);
Expand Down