Skip to content

fix: skip full video download for lazy attachment thumbnails #9045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 25, 2026
Merged

fix: skip full video download for lazy attachment thumbnails #9045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions clients/macos/vellum-assistant/Features/Chat/MediaEmbeds/InlineVideoAttachmentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,19 +176,11 @@ struct InlineVideoAttachmentView: View {
let url = safeTempURL()
do { try data.write(to: url) } catch { return }
fileURL = url
} else if attachment.isLazyLoad,
let port = daemonHttpPort,
let attachmentId = attachment.id.isEmpty ? nil : attachment.id {
// File-backed attachment: fetch from content endpoint.
let url = safeTempURL()
do {
let bytes = try await fetchAttachmentContent(port: port, attachmentId: attachmentId)
try bytes.write(to: url)
} catch {
return
}
fileURL = url
} else {
// For lazy (file-backed) attachments, don't download the full video
// just for a thumbnail — large recordings (100MB+) cause unnecessary
// network traffic and memory pressure. The view already shows a
// play-button placeholder when thumbnailImage is nil.
return
}

Expand Down