Skip to content

Fix type narrowing and add task_routed for duplicate recording #8830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 25, 2026
Merged

Fix type narrowing and add task_routed for duplicate recording #8830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions assistant/src/__tests__/recording-handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('handleRecordingStart', () => {

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);

expect(recordingId).toBeTruthy();
expect(recordingId).not.toBeNull();
// UUID v4 format
expect(recordingId).toMatch(/^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i);

Expand Down Expand Up @@ -201,14 +201,15 @@ describe('handleRecordingStop', () => {

// Start a recording first
const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();
sent.length = 0; // Clear the start message

const result = handleRecordingStop(conversationId, ctx);

expect(result).toBe(recordingId);
expect(result).toBe(recordingId!);
expect(sent).toHaveLength(1);
expect(sent[0].type).toBe('recording_stop');
expect(sent[0].recordingId).toBe(recordingId);
expect(sent[0].recordingId).toBe(recordingId!);
});

test('returns undefined when no active recording exists', () => {
Expand Down Expand Up @@ -249,10 +250,11 @@ describe('recordingHandlers.recording_status', () => {
const conversationId = 'conv-status-1';

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();

const statusMsg: RecordingStatus = {
type: 'recording_status',
sessionId: recordingId,
sessionId: recordingId!,
status: 'started',
};

Expand All @@ -270,14 +272,15 @@ describe('recordingHandlers.recording_status', () => {
ctx.socketToSession.set(fakeSocket, conversationId);

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();
sent.length = 0;

// Add a mock assistant message for the attachment to link to
mockMessages.push({ id: 'existing-msg', role: 'assistant', content: 'Hello' });

const statusMsg: RecordingStatus = {
type: 'recording_status',
sessionId: recordingId,
sessionId: recordingId!,
status: 'stopped',
filePath: '/tmp/recording.mov',
durationMs: 5000,
Expand Down Expand Up @@ -308,13 +311,14 @@ describe('recordingHandlers.recording_status', () => {
ctx.socketToSession.set(fakeSocket, conversationId);

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();
sent.length = 0;

// No existing messages, handler should create one

const statusMsg: RecordingStatus = {
type: 'recording_status',
sessionId: recordingId,
sessionId: recordingId!,
status: 'stopped',
filePath: '/tmp/recording.mp4',
durationMs: 3000,
Expand All @@ -336,11 +340,12 @@ describe('recordingHandlers.recording_status', () => {
mockFileExists = false;

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();
sent.length = 0;

const statusMsg: RecordingStatus = {
type: 'recording_status',
sessionId: recordingId,
sessionId: recordingId!,
status: 'stopped',
filePath: '/tmp/nonexistent.mov',
durationMs: 1000,
Expand All @@ -362,11 +367,12 @@ describe('recordingHandlers.recording_status', () => {
ctx.socketToSession.set(fakeSocket, conversationId);

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();
sent.length = 0;

const statusMsg: RecordingStatus = {
type: 'recording_status',
sessionId: recordingId,
sessionId: recordingId!,
status: 'failed',
error: 'Permission denied',
};
Expand All @@ -390,11 +396,12 @@ describe('recordingHandlers.recording_status', () => {
ctx.socketToSession.set(fakeSocket, conversationId);

const recordingId = handleRecordingStart(conversationId, undefined, fakeSocket, ctx);
expect(recordingId).not.toBeNull();
sent.length = 0;

const statusMsg: RecordingStatus = {
type: 'recording_status',
sessionId: recordingId,
sessionId: recordingId!,
status: 'failed',
};

Expand Down
1 change: 1 addition & 0 deletions assistant/src/daemon/handlers/misc.ts
View file
Open in desktop
Comment thread
Jasonnnz marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ export async function handleTaskSubmit(
ctx.send(socket, { type: 'task_routed', sessionId: conversation.id, interactionType: 'text_qa' });
ctx.send(socket, { type: 'assistant_text_delta', text: 'Starting screen recording.', sessionId: conversation.id });
} else {
ctx.send(socket, { type: 'task_routed', sessionId: conversation.id, interactionType: 'text_qa' });
ctx.send(socket, { type: 'assistant_text_delta', text: 'A recording is already active.', sessionId: conversation.id });
}
ctx.send(socket, { type: 'message_complete', sessionId: conversation.id });
Expand Down