Skip to content

fix: handle polite filler words in recording intent detection #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 25, 2026
Merged

fix: handle polite filler words in recording intent detection #8701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions assistant/src/daemon/recording-intent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ const RECORDING_CLAUSE_PATTERNS: RegExp[] = [
/\brecord\s+(my\s+|the\s+)?screen\s+while\b/i,
];

/** Common polite/filler words stripped before checking intent-only status. */
const FILLER_PATTERN =
/\b(please|pls|plz|can\s+you|could\s+you|would\s+you|now|right\s+now|thanks|thank\s+you|thx|ty|for\s+me|ok(ay)?|hey|hi|just)\b/gi;

// ─── Public API ──────────────────────────────────────────────────────────────

/**
Expand All @@ -66,9 +70,11 @@ export function isRecordingOnly(taskText: string): boolean {

// Strip the recording clause and check if anything substantive remains
const stripped = stripRecordingIntent(taskText);
// If after removing the recording clause, only whitespace/punctuation remains,
// this is a recording-only prompt.
return stripped.replace(/[.,;!?\s]+/g, '').length === 0;
// Also remove common polite/filler words that don't change the intent
const withoutFillers = stripped.replace(FILLER_PATTERN, '');
// If after removing the recording clause and fillers, only whitespace/punctuation
// remains, this is a recording-only prompt.
return withoutFillers.replace(/[.,;!?\s]+/g, '').length === 0;
}

/**
Expand Down Expand Up @@ -117,5 +123,7 @@ export function isStopRecordingOnly(taskText: string): boolean {
if (!detectStopRecordingIntent(taskText)) return false;

const stripped = stripStopRecordingIntent(taskText);
return stripped.replace(/[.,;!?\s]+/g, '').length === 0;
// Also remove common polite/filler words that don't change the intent
const withoutFillers = stripped.replace(FILLER_PATTERN, '');
return withoutFillers.replace(/[.,;!?\s]+/g, '').length === 0;
}