Skip to content

Fix recording handler map leaks: duplicate start + missing socket cleanup #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 25, 2026
Merged

Fix recording handler map leaks: duplicate start + missing socket cleanup #8697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions assistant/src/daemon/handlers/recording.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ export function handleRecordingStart(
): string {
const recordingId = uuid();

const existingRecordingId = recordingOwnerByConversation.get(conversationId);
if (existingRecordingId) {
log.warn({ conversationId, existingRecordingId }, 'Overwriting active recording for conversation');
standaloneRecordingConversationId.delete(existingRecordingId);
}

standaloneRecordingConversationId.set(recordingId, conversationId);
recordingOwnerByConversation.set(conversationId, recordingId);

Expand Down Expand Up @@ -68,6 +74,8 @@ export function handleRecordingStop(
const socket = findSocketForSession(conversationId, ctx);
if (!socket) {
log.warn({ conversationId, recordingId }, 'Cannot send recording_stop: no socket bound to conversation');
standaloneRecordingConversationId.delete(recordingId);
recordingOwnerByConversation.delete(conversationId);
return undefined;
}

Expand Down