Skip to content

Fix stale-start cancel: only skip when state is .recording #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 25, 2026
Merged

Fix stale-start cancel: only skip when state is .recording #8692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistant/ComputerUse/RecordingManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ final class RecordingManager: ObservableObject {
// Only cancel if no other session has taken ownership of the recorder.
// If ownerSessionId points to a different session and the state is active,
// that session now owns the recorder — cancelling would tear down its recording.
if ownerSessionId == nil || !state.isActive {
if ownerSessionId == nil || state != .recording {
Comment thread
Jasonnnz marked this conversation as resolved.
Comment thread
Jasonnnz marked this conversation as resolved.
recorder.cancelRecording()
}
return false
Expand Down