Skip to content

Fix RecordingManager: stale recorder cleanup + forceStop status ordering #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jasonnnz merged 1 commit into from
Feb 25, 2026
Merged

Fix RecordingManager: stale recorder cleanup + forceStop status ordering #8688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions clients/macos/vellum-assistant/ComputerUse/RecordingManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ final class RecordingManager: ObservableObject {
// Guard against stale completion: if stop() or forceStop() was called
// while we were awaiting recorder.start(), don't override the state.
guard state == .starting, ownerSessionId == sessionId else {
log.info("Recording start completed but state changed during await — not overriding (state=\(String(describing: self.state)))")
log.info("Recording start completed but state changed during await — cancelling stale recorder (state=\(String(describing: self.state)))")
recorder.cancelRecording()
Comment thread
Jasonnnz marked this conversation as resolved.
return false
}

Expand Down Expand Up @@ -160,13 +161,13 @@ final class RecordingManager: ObservableObject {
recorder.cancelRecording()

let sessionId = ownerSessionId
state = .idle
ownerSessionId = nil
attachToConversationId = nil

if let sessionId {
sendStatus(sessionId: sessionId, status: "failed", error: "Recording cancelled during shutdown")
}

state = .idle
ownerSessionId = nil
attachToConversationId = nil
log.info("Force-stopped recording (synchronous cancel)")
}

Expand Down