Skip to content

fix: skip ASK_GUARDIAN dispatch when caller is the guardian#8627

Merged
noanflaherty merged 1 commit into
mainfrom
do/fix-guardian-ask-on-call
Feb 25, 2026
Merged

fix: skip ASK_GUARDIAN dispatch when caller is the guardian#8627
noanflaherty merged 1 commit into
mainfrom
do/fix-guardian-ask-on-call

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Feb 25, 2026

Summary

  • voice-session-bridge.ts: Made rule feat: add platform terraform for GKE deployment #2 in the call-control prompt conditional on isCallerGuardian — when the guardian is on the call, the LLM is told to ask them directly instead of using [ASK_GUARDIAN:] markers.
  • call-controller.ts: Added a safety-net guard in the [ASK_GUARDIAN:] handler — if the caller is the guardian, the dispatch is skipped and the question is queued as a pendingInstruction so the LLM asks it directly on the next turn. Added isCallerGuardian() helper method.

Original prompt

Bug: Voice LLM Uses [ASK_GUARDIAN:] When Speaking Directly to the Guardian

When the guardian is on the phone (either inbound or outbound), the voice LLM still emits [ASK_GUARDIAN:] markers to "consult" the guardian. This triggers the full guardian dispatch system (cross-channel notification to Vellum desktop, Telegram, SMS), even though the guardian is right there on the call. The correct behavior is to just ask the question directly in the voice conversation.

🤖 Generated with Claude Code


Open with Devin

When the guardian is on the phone, the voice LLM no longer emits
[ASK_GUARDIAN:] markers. The call-control prompt now tells the model
to ask them directly, and the call controller has a safety-net guard
that intercepts any stray markers and re-injects them as direct
questions instead of dispatching cross-channel notifications.

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty merged commit 95d304c into main Feb 25, 2026
@noanflaherty noanflaherty deleted the do/fix-guardian-ask-on-call branch February 25, 2026 04:03
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant