Skip to content

fix: clear silence timer during active processing to prevent false 'Are you still there?'#8436

Merged
noanflaherty merged 1 commit into
mainfrom
do/fix-silence-timer-during-processing
Feb 25, 2026
Merged

fix: clear silence timer during active processing to prevent false 'Are you still there?'#8436
noanflaherty merged 1 commit into
mainfrom
do/fix-silence-timer-during-processing

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Feb 25, 2026

Summary

  • Clear the silence timer at the start of runTurnInner() so it doesn't fire while the assistant is actively processing (LLM inference, tool calls)
  • Restart the silence timer when the controller returns to idle state (normal completion, abort, error)
  • Leave the timer cleared during waiting_on_user state (consultation timer handles that) and after END_CALL (call is ending)

Original prompt

Bug #3: Silence timeout fires while assistant is actively processing tool calls

Problem: During inbound voice calls, the 30-second silence timer (SILENCE_TIMEOUT_MS in call-constants.ts) fires and sends "Are you still there?" to the caller even when the assistant is actively processing their request (e.g. running LLM inference, executing tool calls like host_bash). The timer only resets on new caller utterances, not on assistant-side activity.

Evidence from logs: In call session ec8230b7, the caller said "Can you tell me how many files I have on my desktop?" at timestamp :65.824. The assistant began processing this request, which involved calling the LLM and then executing host_bash with ls ~/Desktop | wc -l. The host_bash tool permission request didn't fire until :25.871 (60 seconds later), and the tool execution + second LLM turn didn't complete until :28.117. Meanwhile, at :95.831 (exactly 30 seconds after the last caller utterance), the silence timer fired and sent "Are you still there?" even though the assistant was actively working on the caller's request.

Root cause: In assistant/src/calls/call-controller.ts, resetSilenceTimer() is called in handleCallerUtterance() and startInitialGreeting(), but NOT when the controller enters processing or speaking state. The silence timer continues counting down during LLM inference and tool execution. If the total processing time exceeds 30 seconds, the timer fires.

File to modify: assistant/src/calls/call-controller.ts

Fix: Clear the silence timer when entering runTurnInner() (i.e. when the assistant starts actively processing), and only restart it when the controller returns to idle state.

🤖 Generated with Claude Code


Open with Devin

…re you still there?'

Co-Authored-By: Claude <noreply@anthropic.com>
@noanflaherty noanflaherty merged commit 0a5bef8 into main Feb 25, 2026
@noanflaherty noanflaherty deleted the do/fix-silence-timer-during-processing branch February 25, 2026 00:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a349a8ef93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/calls/call-controller.ts
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 4 additional findings in Devin Review.

Open in Devin Review

Comment thread assistant/src/calls/call-controller.ts
Comment thread assistant/src/calls/call-controller.ts
@noanflaherty
Copy link
Copy Markdown
Contributor Author

Addressed in #8639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant