fix: voice barge-in race condition & guardian inbound greeting#8419
Merged
Conversation
- Add retry loop in run-orchestrator before throwing 'Session is already
processing a message' so barge-in teardown has time to complete
- Treat the processing-race error as an expected abort in call-controller
to suppress 'technical issue' fallback message to callers
- Differentiate guardian vs unknown caller on inbound calls so the
assistant answers casually ('Hey!') instead of a formal introduction
Co-Authored-By: Claude <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3b1bd945c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed in #8644 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startRun()would throw "Session is already processing a message" causing the assistant to say "I encountered a technical issue." Now the orchestrator polls briefly (up to 3s) for the previous run to tear down, and the error is treated as an expected abort as defense-in-depth.Original prompt
Bug #1: Race condition — "Session is already processing a message" crashes voice turns
Add retry loop in
run-orchestrator.tsbefore throwing, and recognize the error as expected incall-controller.ts.Bug #2: Assistant greets the caller on inbound calls from the guardian
Thread
isCallerGuardianthroughbuildVoiceCallControlPromptto differentiate greeting behavior.🤖 Generated with Claude Code