Skip to content

fix: handle empty content result distinctly in subagent message callers #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Feb 24, 2026
Merged

fix: handle empty content result distinctly in subagent message callers #8417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions assistant/src/daemon/handlers/subagents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@ export function handleSubagentMessage(
message: `Subagent "${msg.subagentId}" message queue is full. Please wait for current messages to be processed.`,
category: 'queue_full',
});
} else if (result === 'empty') {
log.warn({ subagentId: msg.subagentId }, 'Subagent message rejected — empty content');
ctx.send(socket, {
type: 'error',
message: 'Message content is empty or whitespace-only.',
category: 'empty_content',
});
} else if (result !== 'sent') {
log.warn({ subagentId: msg.subagentId, reason: result }, 'Client sent message to terminal subagent');
ctx.send(socket, {
Expand Down
7 changes: 7 additions & 0 deletions assistant/src/tools/subagent/message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ export async function executeSubagentMessage(
};
}

if (result === 'empty') {
return {
content: 'Message content is empty or whitespace-only.',
isError: true,
};
}

if (result !== 'sent') {
return {
content: `Could not send message to subagent "${subagentId}". It may not exist or be in a terminal state.`,
Expand Down