Skip to content

fix: unreserve dedup cache entries on CircuitBreakerOpenError before returning 503 #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Feb 24, 2026
Merged

fix: unreserve dedup cache entries on CircuitBreakerOpenError before returning 503 #8394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gateway/src/http/routes/telegram-webhook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ export function createTelegramWebhookHandler(config: GatewayConfig) {
} catch (err) {
if (err instanceof CircuitBreakerOpenError) {
acknowledgeCallbackQuery(normalized.message.callbackQueryId, "start_command_circuit_open");
if (updateId !== undefined) dedupCache.unreserve(updateId);
return Response.json(
{ error: "Service temporarily unavailable" },
{ status: 503, headers: { "Retry-After": String(err.retryAfterSecs) } },
Expand Down Expand Up @@ -490,6 +491,7 @@ export function createTelegramWebhookHandler(config: GatewayConfig) {
if (err instanceof CircuitBreakerOpenError) {
tlog.warn({ retryAfterSecs: err.retryAfterSecs }, "Circuit breaker open — returning 503");
if (isCallback) acknowledgeCallbackQuery(normalized.message.callbackQueryId, "circuit_open");
if (updateId !== undefined) dedupCache.unreserve(updateId);
return Response.json(
{ error: "Service temporarily unavailable" },
{ status: 503, headers: { "Retry-After": String(err.retryAfterSecs) } },
Expand Down
1 change: 1 addition & 0 deletions gateway/src/http/routes/twilio-sms-webhook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ export function createTwilioSmsWebhookHandler(config: GatewayConfig) {
} catch (err) {
if (err instanceof CircuitBreakerOpenError) {
tlog.warn({ retryAfterSecs: err.retryAfterSecs }, "Circuit breaker open — returning 503");
dedupCache.unreserve(messageSid);
return Response.json(
{ error: "Service temporarily unavailable" },
{ status: 503, headers: { "Retry-After": String(err.retryAfterSecs) } },
Expand Down
1 change: 1 addition & 0 deletions gateway/src/http/routes/whatsapp-webhook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ export function createWhatsAppWebhookHandler(config: GatewayConfig) {
} catch (err) {
if (err instanceof CircuitBreakerOpenError) {
tlog.warn({ retryAfterSecs: err.retryAfterSecs }, "Circuit breaker open — returning 503");
dedupCache.unreserve(whatsappMessageId);
return Response.json(
{ error: "Service temporarily unavailable" },
{ status: 503, headers: { "Retry-After": String(err.retryAfterSecs) } },
Expand Down
Loading