Skip to content

fix: add explicit self. for property captures in PorcupineWakeWordEngine #8337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent0426 merged 1 commit into from
Feb 24, 2026
Merged

fix: add explicit self. for property captures in PorcupineWakeWordEngine #8337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions clients/macos/vellum-assistant/Features/Voice/WakeWord/PorcupineWakeWordEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ final class PorcupineWakeWordEngine: WakeWordEngine {
// 5. Keyword path
let keywordPath: String
let keywordDir = resourceURL.appendingPathComponent("porcupine-keywords")
let builtinPath = keywordDir.appendingPathComponent(keyword.lowercased() + "_mac.ppn").path
let builtinPath = keywordDir.appendingPathComponent(self.keyword.lowercased() + "_mac.ppn").path
if FileManager.default.fileExists(atPath: builtinPath) {
keywordPath = builtinPath
} else if keyword.hasPrefix("/") && FileManager.default.fileExists(atPath: keyword) {
} else if self.keyword.hasPrefix("/") && FileManager.default.fileExists(atPath: self.keyword) {
// Treat keyword as an absolute path to a custom .ppn file
keywordPath = keyword
keywordPath = self.keyword
} else {
log.error("Keyword file not found: tried \(builtinPath) and absolute path \(keyword)")
log.error("Keyword file not found: tried \(builtinPath) and absolute path \(self.keyword)")
return
}

Expand All @@ -100,7 +100,7 @@ final class PorcupineWakeWordEngine: WakeWordEngine {
accessKey: accessKey,
modelPath: modelPath,
keywordPaths: [keywordPath],
sensitivities: [sensitivity]
sensitivities: [self.sensitivity]
)
} catch {
log.error("Failed to initialize Porcupine engine: \(error)")
Expand Down