Skip to content

fix: prevent double dismiss of Quick Input panel on submit #8315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent0426 merged 1 commit into from
Feb 24, 2026
Merged

fix: prevent double dismiss of Quick Input panel on submit #8315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion clients/macos/vellum-assistant/Features/QuickInput/QuickInputWindow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ final class QuickInputWindow {
private var panel: NSPanel?
private var resignObserver: Any?
private var previousApp: NSRunningApplication?
private var isDismissing = false

/// Callback invoked when the user submits a message.
var onSubmit: ((String) -> Void)?
Expand Down Expand Up @@ -91,12 +92,18 @@ final class QuickInputWindow {
}

func dismiss(restorePreviousApp: Bool = true) {
guard !isDismissing else { return }
isDismissing = true

if let resignObserver {
NotificationCenter.default.removeObserver(resignObserver)
}
resignObserver = nil

guard let panel else { return }
guard let panel else {
isDismissing = false
return
}

let appToRestore = restorePreviousApp ? previousApp : nil
previousApp = nil
Expand All @@ -108,6 +115,7 @@ final class QuickInputWindow {
}, completionHandler: { [weak self] in
panel.close()
self?.panel = nil
self?.isDismissing = false
appToRestore?.activate()
})
}
Expand Down