Skip to content

fix(macos): resolve CI build errors in settings views #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Feb 24, 2026
Merged

fix(macos): resolve CI build errors in settings views #8306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions clients/macos/vellum-assistant/Features/MainWindow/Panels/SettingsPanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,9 +1183,8 @@ private struct ModelPickerItem: View {
}
}

// MARK: - Environment Variables Sheet (Debug Only)
// MARK: - Environment Variables Sheet

#if DEBUG
struct SettingsPanelEnvVarsSheet: View {
let appEnvVars: [(String, String)]
let daemonEnvVars: [(String, String)]
Expand Down Expand Up @@ -1243,7 +1242,6 @@ struct SettingsPanelEnvVarsSheet: View {
}
}
}
#endif

struct SettingsPanel_Previews: PreviewProvider {
static var previews: some View {
Expand Down
12 changes: 6 additions & 6 deletions clients/macos/vellum-assistant/Features/Settings/SettingsConnectTab.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ struct SettingsConnectTab: View {
return "arrow.trianglehead.2.counterclockwise"
}
switch store.vellumPlatformReachable {
case true: return "checkmark.circle.fill"
case false: return "xmark.circle.fill"
case nil: return "questionmark.circle"
case .some(true): return "checkmark.circle.fill"
case .some(false): return "xmark.circle.fill"
case .none: return "questionmark.circle"
}
}

Expand All @@ -117,9 +117,9 @@ struct SettingsConnectTab: View {
return VColor.textMuted
}
switch store.vellumPlatformReachable {
case true: return VColor.success
case false: return VColor.error
case nil: return VColor.textMuted
case .some(true): return VColor.success
case .some(false): return VColor.error
case .none: return VColor.textMuted
}
}

Expand Down