Skip to content

security: enforce file permissions on log files #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Feb 24, 2026
Merged

security: enforce file permissions on log files #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assistant/src/util/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function buildRotatingLogger(config: LogFileConfig): pino.Logger {

const today = formatDate(new Date());
const filePath = logFilePathForDate(config.dir, new Date());
const fileStream = pino.destination({ dest: filePath, sync: false, mkdir: true });
const fileStream = pino.destination({ dest: filePath, sync: false, mkdir: true, mode: 0o600 });

activeLogDate = today;
activeLogFileConfig = config;
Expand Down Expand Up @@ -130,7 +130,7 @@ function getRootLogger(): pino.Logger {
}

try {
const fileStream = pino.destination({ dest: getLogPath(), sync: false, mkdir: true });
const fileStream = pino.destination({ dest: getLogPath(), sync: false, mkdir: true, mode: 0o600 });
Comment thread
siddseethepalli marked this conversation as resolved.

if (getDebugMode()) {
const prettyStream = pinoPretty({ destination: 2 });
Expand Down
2 changes: 1 addition & 1 deletion gateway/src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function buildLogger(config: LogFileConfig | null): pino.Logger {

const today = formatDate(new Date());
const filePath = logFilePathForDate(config.dir, new Date());
const fileStream = pino.destination({ dest: filePath, sync: false, mkdir: true });
const fileStream = pino.destination({ dest: filePath, sync: false, mkdir: true, mode: 0o600 });

activeLogDate = today;
activeConfig = config;
Expand Down
Loading