Skip to content

fix: remove Porcupine iOS-only SPM dep that breaks Xcode 26.2 build #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-nork merged 1 commit into from
Feb 24, 2026
Merged

fix: remove Porcupine iOS-only SPM dep that breaks Xcode 26.2 build #8240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions clients/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions clients/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/sparkle-project/Sparkle", from: "2.0.0"),
.package(url: "https://github.com/Picovoice/porcupine", from: "3.0.0"),
// Porcupine removed — iOS-only SPM package breaks on Xcode 26.2.
// TODO: Re-add via C SDK wrapper (lib/mac/) for macOS wake word support.
],
targets: [
.target(
Expand All @@ -49,7 +50,7 @@ let package = Package(
dependencies: [
"VellumAssistantShared",
"Sparkle",
.product(name: "Porcupine", package: "porcupine"),
// Porcupine dep removed — stub engine doesn't need it
],
path: "macos/vellum-assistant",
exclude: ["Resources/Info.plist", "Resources/bg.png"],
Expand Down
1 change: 1 addition & 0 deletions clients/macos/vellum-assistant/Features/Settings/WakeWordSettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import SwiftUI
import VellumAssistantShared

/// Wake word settings tab — enable/disable wake word listening,
/// configure Picovoice access key, sensitivity, and conversation timeout.
Expand Down
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistant/Features/Voice/WakeWord/PorcupineWakeWordEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ final class PorcupineWakeWordEngine: WakeWordEngine {
}

/// Feed a buffer of 16-bit PCM audio samples for wake word detection.
func process(pcm: [Int16]) {
func processAudioFrame(_ frame: [Int16]) {
// Stub — real implementation will call Porcupine's process() here
}
}
3 changes: 2 additions & 1 deletion clients/macos/vellum-assistant/Features/Voice/WakeWord/WakeWordCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Foundation
import Combine
import VellumAssistantShared
import os

private let log = Logger(subsystem: "com.vellum.vellum-assistant", category: "WakeWordCoordinator")
Expand Down Expand Up @@ -77,7 +78,7 @@ final class WakeWordCoordinator: ObservableObject {

// Ignore if voice mode is already active
guard voiceModeManager.state == .off else {
log.info("Wake word ignored — voice mode already active (state: \(String(describing: voiceModeManager.state)))")
log.info("Wake word ignored — voice mode already active (state: \(String(describing: self.voiceModeManager.state)))")
return
}

Expand Down
Loading