Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions assistant/src/memory/db-init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
migrateGuardianActionTables,
migrateBackfillInboxThreadStateFromBindings,
migrateDropActiveSearchIndex,
migrateMemorySegmentsIndexes,
validateMigrationState,
} from './schema-migration.js';

Expand Down Expand Up @@ -1267,5 +1268,7 @@ export function initializeDb(): void {

migrateMemoryFtsBackfill(database);

migrateMemorySegmentsIndexes(database);

validateMigrationState(database);
}
11 changes: 11 additions & 0 deletions assistant/src/memory/migrations/016-memory-segments-indexes.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import type { DrizzleDb } from '../db-connection.js';

/**
* Idempotent migration to ensure memory_segments has indexes on scope_id and
* conversation_id for faster lookups. scope_id was already covered by
* db-init, but we include both here for completeness.
*/
export function migrateMemorySegmentsIndexes(database: DrizzleDb): void {
database.run(/*sql*/ `CREATE INDEX IF NOT EXISTS idx_memory_segments_scope_id ON memory_segments(scope_id)`);
database.run(/*sql*/ `CREATE INDEX IF NOT EXISTS idx_memory_segments_conversation_id ON memory_segments(conversation_id)`);
Comment thread
siddseethepalli marked this conversation as resolved.
}
1 change: 1 addition & 0 deletions assistant/src/memory/migrations/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ export { migrateCallSessionsAddInitiatedFrom } from './012-call-sessions-add-ini
export { migrateGuardianActionTables } from './013-guardian-action-tables.js';
export { migrateBackfillInboxThreadStateFromBindings } from './014-backfill-inbox-thread-state.js';
export { migrateDropActiveSearchIndex } from './015-drop-active-search-index.js';
export { migrateMemorySegmentsIndexes } from './016-memory-segments-indexes.js';
1 change: 1 addition & 0 deletions assistant/src/memory/schema-migration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ export {
migrateGuardianActionTables,
migrateBackfillInboxThreadStateFromBindings,
migrateDropActiveSearchIndex,
migrateMemorySegmentsIndexes,
} from './migrations/index.js';
7 changes: 5 additions & 2 deletions assistant/src/memory/schema.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { sqliteTable, text, integer, real, blob } from 'drizzle-orm/sqlite-core';
import { sqliteTable, text, integer, real, blob, index } from 'drizzle-orm/sqlite-core';

export const conversations = sqliteTable('conversations', {
id: text('id').primaryKey(),
Expand Down Expand Up @@ -58,7 +58,10 @@ export const memorySegments = sqliteTable('memory_segments', {
contentHash: text('content_hash'),
createdAt: integer('created_at').notNull(),
updatedAt: integer('updated_at').notNull(),
});
}, (table) => [
index('idx_memory_segments_scope_id').on(table.scopeId),
index('idx_memory_segments_conversation_id').on(table.conversationId),
]);

export const memoryItems = sqliteTable('memory_items', {
id: text('id').primaryKey(),
Expand Down