feat: M9 — Legacy Pairing Removal + Upgrade Migration#8149
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ashleeradka
force-pushed
the
simplify-pairing/m8
branch
from
ab1fa08 to
3721440
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24b68bcbc0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ashleeradka
force-pushed
the
simplify-pairing/m9
branch
from
24b68bc to
3224320
Compare
ashleeradka
force-pushed
the
simplify-pairing/m8
branch
from
3721440 to
0401735
Compare
Remove legacy v2/v3 pairing code paths, manual setup UI, and developer local pairing toggle. Simplify PairingConfiguration to only expose override keys (no more overrideEnabledKey). Update ARCHITECTURE.md with v4 pairing flow documentation. Clean up iOS and macOS README/CLAUDE docs to reflect the new pairing model. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ashleeradka
force-pushed
the
simplify-pairing/m9
branch
from
3224320 to
59eeed6
Compare
Contributor
Author
|
Addressed in #8197 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all legacy v2/v3 pairing code, the manual setup UI, and the developer local pairing toggle. Updates documentation to reflect the v4 pairing model.
Changes
PairingConfiguration.swift— RemovedoverrideEnabledKeyandisOverrideEnabled; simplified to gateway/token override keys onlySettingsConnectTab.swift— RemovediosPairingUseOverrideandlanUrlCopiedstate; simplified token status logicConnectionSettingsSection.swift— RemovedManualSetupView,isLocalHost, and updated "not configured" textUserDefaultsKeys.swift— Updated for v4 pairingDaemonConfig.swift— Updated for v4 pairingclients/ios/App/AppDelegate.swift— Updated for v4 pairingARCHITECTURE.md— Replaced Pairing Methods section with v4 Pairing Flow documentationclients/ios/README.md,clients/macos/README.md,clients/macos/CLAUDE.md— Updated pairing documentationStack
M9 of 9 — Simplify Pairing + Mac Approval