feat: M5 — macOS v4 QR Code Generation#8132
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 129697eb92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ashleeradka
force-pushed
the
simplify-pairing/m4
branch
from
766a3f9 to
d188d1f
Compare
Rewrite PairingQRCodeSheet to use daemon-driven pairing flow. The sheet now registers a pairing request via DaemonClient and generates a v4 QR payload containing a pairingRequestId and pairingSecret. Add lanPairingUrl computed property to SettingsStore for automatic LAN URL discovery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ashleeradka
force-pushed
the
simplify-pairing/m5
branch
from
129697e to
471b1b7
Compare
Contributor
Author
|
Addressed in #8199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the QR code sheet to use the v4 daemon-driven pairing flow instead of embedding credentials directly in the QR payload.
Changes
PairingQRCodeSheet.swift— Full rewrite: registers pairing request via DaemonClient, generates v4 QR payload with pairingRequestId/pairingSecretSettingsConnectTab.swift— Updated sheet to pass daemonClient instead of raw credentialsSettingsStore.swift— AddedlanPairingUrlcomputed property for automatic LAN URL discoveryStack
M5 of 9 — Simplify Pairing + Mac Approval