fix: resolve hardcoded port 7821 and wrong token path in browser relay#8114
Merged
Conversation
…y and Chrome extension Co-Authored-By: Claude <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84f2e30e2b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
Addressed in #8301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Codex review feedback on #8089:
assistant/src/amazon/client.ts: derive runtime HTTP port fromgetRuntimeHttpPort() ?? 7821instead of hardcoding 7821 in the HTTP fallback path ofsendRelayCommandclients/chrome-extension/background/worker.ts: make relay port configurable viachrome.storage.local(relayPortkey);connect()now reads the stored port (defaulting to 7821) to build the WebSocket URL dynamicallyclients/chrome-extension/popup/popup.html+popup.ts: add a port input field to let users configure a non-default relay port; fix token file path typo (http_token→http-token)clients/chrome-extension/build.sh: fix samehttp_token→http-tokentypo in install instructions