Skip to content

fix: guard buildChunks infinite loop and use ?? for chunk inputs #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-nork merged 1 commit into from
Feb 24, 2026
Merged

fix: guard buildChunks infinite loop and use ?? for chunk inputs #7787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions assistant/src/config/bundled-skills/media-processing/tools/analyze-keyframes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Return a JSON array of these objects, one per frame. Return ONLY the JSON array,

function buildChunks(keyframes: MediaKeyframe[], chunkSize: number, overlap: number): MediaKeyframe[][] {
const chunks: MediaKeyframe[][] = [];
const step = chunkSize - overlap;
const step = Math.max(1, chunkSize - overlap);
for (let i = 0; i < keyframes.length; i += step) {
chunks.push(keyframes.slice(i, i + chunkSize));
}
Expand Down Expand Up @@ -275,9 +275,9 @@ export async function run(
}

const analysisType = (input.analysis_type as string) || 'scene_description';
const batchSize = (input.batch_size as number) || 10;
const chunkSizeInput = (input.chunk_size as number) || 10;
const overlapInput = (input.overlap as number) || 2;
const batchSize = (input.batch_size as number) ?? 10;
const chunkSizeInput = (input.chunk_size as number) ?? 10;
Comment thread
alex-nork marked this conversation as resolved.
Comment thread
alex-nork marked this conversation as resolved.
const overlapInput = (input.overlap as number) ?? 2;

try {
// Check if all keyframes are already analyzed before calling the core function
Expand Down
Loading