M2: Implement chunked analysis with multi-frame VLM prompt#7781
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3352e770ad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
Addressed in #7787 |
sarahkatebyte
pushed a commit
that referenced
this pull request
May 29, 2026
Companion to platform commit vellum-ai/vellum-assistant-platform@6aa58423e, which removes the `can_delete_payment_method` field from `AutoTopUpConfigResponse` per Carson's comment #1 on PR #7781: > can_delete_payment_method is redundant if only driven off whether or > not user is on pro plan The rule reduces to `plan_id == PRO`, so a server-authored boolean was redundant — the frontend can read `subscription.plan_id` directly. Changes: - payment-methods-card.tsx: re-add `useQuery(organizationsBilling SubscriptionRetrieveOptions())`, derive `isPro` locally, gate the Remove button on `!isPro` instead of the deleted `config.can_delete_payment_method`. Two ConfirmDialog variants for non-Pro users (auto-top-up on vs off) stay in place. - auto-top-up-card.tsx: drop `can_delete_payment_method: true` from the `DISABLED_CONFIG` seed (field no longer exists on the type). - openapi-schemas/platform.yaml: re-synced from platform repo post-Carson-fix; field is now absent from `AutoTopUpConfigResponse`. - generated/api/types.gen.ts (regen via `bun run openapi-ts`): `can_delete_payment_method: boolean` removed from `AutoTopUpConfigResponse`. - payment-methods-card.test.tsx: rewrite the three render tests to mock the subscription query instead of `config.can_delete_payment_ method`. Same cases: Base + saved card → Change + Remove; Pro + saved card → Change only; no saved card → Add Card only. Backend enforcement (`AutoTopUpViewSet.remove_payment_method` + `PaymentMethodViewSet.destroy` both return `409` for Pro plans) stays in place as the authoritative safety net. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7766. Rewrites analyze-keyframes to group frames into overlapping chunks (default 10 frames, 2 overlap) and analyze each chunk in a single multi-image API call. This provides temporal context for better event detection and reduces API calls by ~8x (e.g. 205 frames -> ~26 calls instead of 205).